fix(inject): detect references inside object destructuring (#1241)

* Fix: doesn't detect references in destructed object value

* Fix: pass the linetr

* Update snapshot

packages/inject/src/index.js

@@ -167,7 +167,7 @@ export default function inject(options) {
 
           // special case – shorthand properties. because node.key === node.value,
           // we can't differentiate once we've descended into the node
-          if (node.type === 'Property' && node.shorthand) {
+          if (node.type === 'Property' && node.shorthand && node.value.type === 'Identifier') {
             const { name } = node.key;
             handleReference(node, name, name);
             this.skip();

packages/inject/test/fixtures/shorthand-assignment/input.js

@@ -0,0 +1,3 @@
+const { Promise = "fallback" } = foo;
+console.log(Promise);
+

packages/inject/test/fixtures/shorthand-func-fallback/input.js

@@ -0,0 +1,5 @@
+function foo({bar = Promise}) {
+  console.log(bar);
+}
+foo();
+

packages/inject/test/fixtures/shorthand-func/input.js

@@ -0,0 +1,5 @@
+function foo({Promise}) {
+  console.log(Promise);
+}
+foo();
+

packages/inject/test/snapshots/test.js.md

@@ -103,6 +103,39 @@ Generated by [AVA](https://avajs.dev).
     polyfills.Promise.resolve().then(() => 'it works');␊
     `
 
+## handles shorthand properties (as assignment)
+
+> Snapshot 1
+
+    `const { Promise = "fallback" } = foo;␊
+    console.log(Promise);␊
+    ␊
+    `
+
+## handles shorthand properties in function
+
+> Snapshot 1
+
+    `function foo({Promise}) {␊
+      console.log(Promise);␊
+    }␊
+    foo();␊
+    ␊
+    `
+
+## handles shorthand properties in function (as fallback value)
+
+> Snapshot 1
+
+    `import { Promise as Promise } from 'es6-promise';␊
+    ␊
+    function foo({bar = Promise}) {␊
+      console.log(bar);␊
+    }␊
+    foo();␊
+    ␊
+    `
+
 ## handles redundant keys
 
 > Snapshot 1

packages/inject/test/test.js

@@ -70,6 +70,18 @@ test('handles shorthand properties', (t) => {
   compare(t, 'shorthand', { Promise: ['es6-promise', 'Promise'] });
 });
 
+test('handles shorthand properties (as assignment)', (t) => {
+  compare(t, 'shorthand-assignment', { Promise: ['es6-promise', 'Promise'] });
+});
+
+test('handles shorthand properties in function', (t) => {
+  compare(t, 'shorthand-func', { Promise: ['es6-promise', 'Promise'] });
+});
+
+test('handles shorthand properties in function (as fallback value)', (t) => {
+  compare(t, 'shorthand-func-fallback', { Promise: ['es6-promise', 'Promise'] });
+});
+
 test('handles redundant keys', (t) => {
   compare(t, 'redundant-keys', {
     Buffer: 'Buffer',