refactor(commonjs): Inline __esModule handling into export generation

rollup · Nov 24, 2020 · e8948a0 · e8948a0
1 parent f6fb5be
commit e8948a0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 17 deletions.
diff --git a/packages/commonjs/src/generate-exports.js b/packages/commonjs/src/generate-exports.js
@@ -18,7 +18,6 @@ export function rewriteExportsAndGetExportsBlock(
   topLevelExportsAssignmentsByName,
   defineCompiledEsmExpressions,
   deconflict,
-  isRestorableCompiledEsm,
   code,
   uses,
   HELPERS_NAME,
@@ -68,6 +67,19 @@ export function rewriteExportsAndGetExportsBlock(
       );
     }
 
+    // Collect and rewrite exports.__esModule assignments
+    let isRestorableCompiledEsm = false;
+    for (const expression of defineCompiledEsmExpressions) {
+      isRestorableCompiledEsm = true;
+      const moduleExportsExpression =
+        expression.type === 'CallExpression' ? expression.arguments[0] : expression.left.object;
+      magicString.overwrite(
+        moduleExportsExpression.start,
+        moduleExportsExpression.end,
+        `${moduleName}.exports`
+      );
+    }
+
     if (isRestorableCompiledEsm) {
       exportDeclarations.push(
         deconflictedDefaultExportName

diff --git a/packages/commonjs/src/transform-commonjs.js b/packages/commonjs/src/transform-commonjs.js
@@ -324,21 +324,6 @@ export default function transformCommonjs(
   // TODO Lukas we do not need this for ES modules
   const moduleName = deconflict(scope, globals, getName(id));
 
-  // TODO Lukas inline this into exports block
-  let isRestorableCompiledEsm = false;
-  if (!shouldWrap) {
-    for (const expression of defineCompiledEsmExpressions) {
-      isRestorableCompiledEsm = true;
-      const moduleExportsExpression =
-        expression.type === 'CallExpression' ? expression.arguments[0] : expression.left.object;
-      magicString.overwrite(
-        moduleExportsExpression.start,
-        moduleExportsExpression.end,
-        `${moduleName}.exports`
-      );
-    }
-  }
-
   // We cannot wrap ES/mixed modules
   shouldWrap = shouldWrap && !disableWrap && !isEsModule;
   uses.commonjsHelpers = uses.commonjsHelpers || shouldWrap;
@@ -374,7 +359,6 @@ export default function transformCommonjs(
         topLevelExportsAssignmentsByName,
         defineCompiledEsmExpressions,
         (name) => deconflict(scope, globals, name),
-        isRestorableCompiledEsm,
         code,
         uses,
         HELPERS_NAME,