fix(pluginutils): fix path normalisation for createFilter #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
requested changes
Apr 12, 2022
r0b1n
force-pushed
the
fix/plugginutils/filter-normalization
branch
from
17dbb7e
to
4ca9717
Compare
shellscape
approved these changes
Apr 12, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
pluginutilsThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Discovered in #1144
Description
createFilterfunction is not normalizing paths correctly. Everything is expected to be converted to/while on windows it may not be the case as it depends on users input.