Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(url): update pluginutils deps, extend tests #1144

Merged
merged 1 commit into from Apr 29, 2022

Conversation

r0b1n
Copy link
Contributor

@r0b1n r0b1n commented Mar 18, 2022

Rollup Plugin Name: url

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (Included test that requires update of dependencies)
  • no

Breaking Changes?

  • yes (Dependencies update, major version bump)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Fixes issue with url module by bumping @rollup/pluginutils dependencies to v4. Tests that reproduce the issue on v3 are included. The issue is related to incorrect handling of absolute pathes in @rollup/pluginutils v3.

This is a major dependencies bump, so the version of this module is bumped as well to 7.0.0.

@r0b1n r0b1n requested a review from shellscape as a code owner March 18, 2022 09:25
@shellscape
Copy link
Collaborator

Looks like there's a failure in CI on Windows from your changes, please have a look.

@r0b1n
Copy link
Contributor Author

r0b1n commented Apr 12, 2022

@shellscape thanks for running the CI checks. I found an issue. It is an oversight in pluginutils@4.2.0. I added a workaround.

Here if id is an absolute path, it doesn't do anything to it. That is I think not what should happen, is should still normalize paths regardless. That is also true for paths starting with *, it should normalize path starting with * because those may still contain windows style \ slashes inside. It still should not append resolution base of course, but normalize.

@shellscape
Copy link
Collaborator

We got #1161 published yesterday so you should be good to update for that fix. Nice work finding the issue.

@shellscape shellscape merged commit 689aba3 into rollup:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants