Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-resolve): fix error when custom resolve option missing #1029

Closed
wants to merge 1 commit into from

Conversation

tjenkinson
Copy link
Member

Rollup Plugin Name: node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: fixes #1023

Description

I think older rollup versions will not provide custom, so we should handle it being undefined, as we did before #1016

There is not test for this, but to test it we either need to fake a call or somehow being in an older rollup version for the test.

@shellscape
Copy link
Collaborator

Unless there's a 2.x version of rollup which also lacks that, we don't have to account for this scenario. see: #1023 (comment)

@tjenkinson
Copy link
Member Author

Ah yep good spot. Not sure when custom was added?

@tjenkinson
Copy link
Member Author

custom was added in rollup 2.29.0 and our peer dependency is ^2.42.0, so closing this

@tjenkinson tjenkinson closed this Oct 30, 2021
@tjenkinson tjenkinson deleted the node-resolve-custom-fix branch October 30, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@rollup/plugin-node-resolve] Cannot read property 'custom' of undefined
2 participants