fix(typescript): allow lowercase drive letters #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shellscape Is there anything more this needs? |
|
@timvahlbrock thanks for this PR. we're getting to them as soon as we're able to. In this case it looks like someone beat you to the punch on #1134. But seriously thanks for the PR, and for helping on the issue. If you'd like, I can edit the CHANGELOG and add your handle for credit. Closing for now, but please let me know if you'd like me to do that. |
Appreciate it, but I don't think that would be appropriate. Just oversaw the existing pull request and wanted to get this solved. Maybe if I contribute something another time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
{typescript}This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
The regex that converts drive letters is now transforming lower case drive letters as well.
I'm aware that bugfixes should normally receive tests, however tests for this case cannot easily be build, as this occurrence of this bug depends on operating system configuration and the shell being used.