Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commonjs): support CJS modules re-exporting transpiled ESM modules #1165

Merged
merged 34 commits into from Apr 24, 2022
Merged

fix(commonjs): support CJS modules re-exporting transpiled ESM modules #1165

merged 34 commits into from Apr 24, 2022

Commits on Apr 3, 2022

  1. fix(commonjs): attach correct plugin meta-data to commonjs modules

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    f829b36 View commit details
    Browse the repository at this point in the history

  2. feat(commonjs): reimplement dynamic import handling 

    BREAKING CHANGES: requires Node 12
No longer supports require.cache
    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    1393c7c View commit details
    Browse the repository at this point in the history

  3. feat(commonjs): add strictRequires option to wrap modules

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    35770bd View commit details
    Browse the repository at this point in the history

  4. feat(commonjs): automatically wrap cyclic modules

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    81628db View commit details
    Browse the repository at this point in the history

  5. feat(commonjs): Infer type for unidentified modules

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    93cf5fb View commit details
    Browse the repository at this point in the history

  6. feat(commonjs): make namespace callable when requiring ESM with funct… 

    …ion default
    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    8d31f25 View commit details
    Browse the repository at this point in the history

  7. fix(commonjs): handle relative external imports

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    fb490c0 View commit details
    Browse the repository at this point in the history

  8. feat(commonjs): limit ignoreTryCatch to external requires

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    e672b42 View commit details
    Browse the repository at this point in the history

  9. feat(commonjs): auto-detect conditional requires

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    748f8ba View commit details
    Browse the repository at this point in the history

  10. feat(commonjs): add dynamicRequireRoot option

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    c399755 View commit details
    Browse the repository at this point in the history

  11. feat(commonjs): throw for dynamic requires from outside the configure… 

    …d root
    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    4a84215 View commit details
    Browse the repository at this point in the history

  12. refactor(commonjs): deconflict helpers only once globals are known

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    7e2691a View commit details
    Browse the repository at this point in the history

  13. feat(commonjs): expose plugin version

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    a16a3cd View commit details
    Browse the repository at this point in the history

  14. fix(commonjs): do not transform "typeof exports" for mixed modules 

    resolves rollup#1014
    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    46776c6 View commit details
    Browse the repository at this point in the history

  15. fix(commonjs): inject module name into dynamic require function

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    373684d View commit details
    Browse the repository at this point in the history

  16. fix(commonjs): validate node-resolve peer version

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    b7e0d7e View commit details
    Browse the repository at this point in the history

  17. fix(commonjs): use correct version and add package exports

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    45a3141 View commit details
    Browse the repository at this point in the history

  18. fix(commonjs): proxy all entries to not break legacy polyfill plugins

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    12dbaa3 View commit details
    Browse the repository at this point in the history

  19. fix(commonjs): add heuristic to deoptimize requires after calling imp… 

    …orted function
    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    0fb0303 View commit details
    Browse the repository at this point in the history

  20. fix(commonjs): make sure type changes of esm imports are tracked 

    BREAKING CHANGES: Requires at least rollup@2.68.0
    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    ebc1cb1 View commit details
    Browse the repository at this point in the history

  21. fix(commonjs): handle external dependencies when using the cache

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    b61845f View commit details
    Browse the repository at this point in the history

  22. fix(commonjs): Do not change semantics when removing requires in if s… 

    …tatements
    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    b1110d2 View commit details
    Browse the repository at this point in the history

  23. fix(commonjs): Allow to dynamically require an empty file

    @lukastaegert
    lukastaegert committed Apr 3, 2022
    Copy the full SHA
    f509b1a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Add a test to illustrate problematic re-exported module 

    This is exhibited for example in Next.js, see https://github.com/vercel/next.js/blob/5feb400aff8e7b8968174b4e339b98ce48412180/packages/next/link.js#L1 which doesn't specify __esModule but re-exports a module that does.

See https://www.runpkg.com/?next@12.1.4/link.js and https://www.runpkg.com/?next@12.1.4/dist/client/link.js for the compiled example.
    @fwouts
    fwouts committed Apr 8, 2022
    Copy the full SHA
    347c148 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. fix(commonjs): support CJS modules re-exporting ESM modules

    @fwouts
    fwouts committed Apr 16, 2022
    Copy the full SHA
    2749ea9 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. fix(commonjs): Warn when plugins do not pass options to resolveId

    @lukastaegert
    lukastaegert committed Apr 18, 2022
    Copy the full SHA
    d637611 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge remote-tracking branch 'upstream/commonjs/strict-require-order'… 

    … into cjs-reexport
    @fwouts
    fwouts committed Apr 19, 2022
    Copy the full SHA
    095491b View commit details
    Browse the repository at this point in the history

  2. Update snapshots post-merge

    @fwouts
    fwouts committed Apr 19, 2022
    Copy the full SHA
    e3b4b0c View commit details
    Browse the repository at this point in the history

  3. Update tests

    @fwouts
    fwouts committed Apr 19, 2022
    Copy the full SHA
    c77baef View commit details
    Browse the repository at this point in the history

  4. Update snapshot

    @fwouts
    fwouts committed Apr 19, 2022
    Copy the full SHA
    4863298 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary fixtures

    @fwouts
    fwouts committed Apr 19, 2022
    Copy the full SHA
    159336a View commit details
    Browse the repository at this point in the history

  6. Remove comment given other tests do exactly the same 

    See:
- https://github.com/rollup/plugins/blob/d637611a79a2701c359f5f2f6ffb49978070da38/packages/commonjs/test/fixtures/function/transpiled-esm-entry-named/main.js#L3
- https://github.com/rollup/plugins/blob/d637611a79a2701c359f5f2f6ffb49978070da38/packages/commonjs/test/fixtures/function/transpiled-esm-namespace-named/main.js#L5
    @fwouts
    fwouts committed Apr 19, 2022
    Copy the full SHA
    981918d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Update snapshots

    @lukastaegert
    lukastaegert committed Apr 24, 2022
    Copy the full SHA
    205b187 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/commonjs/strict-require-order'… 

    … into cjs-reexport
    @lukastaegert
    lukastaegert committed Apr 24, 2022
    Copy the full SHA
    224f904 View commit details
    Browse the repository at this point in the history