fix: support .mts and .cts out of the box #1249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
requested changes
Aug 28, 2022
RebeccaStevens
requested review from
NotWoods
and removed request for
shellscape
|
For what it's worth, I think #1194 already adds support for this? |
|
Yeah, that's true. It would be good if we can get one of these merged soon as currently libraries using the |
|
Thanks for the work on this PR. #1194 supersedes this PR and we've just merged that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Currently out of the box the
typescriptplugin only supports.tsand.tsxextensions. This PR adds support for.mtsand.ctsas well without the user needing to modify theincludesoption.Additionally only
.d.tswere supported as type declaration files, this PR also adds support for.d.mtsand.d.ctsfiles.