fix(typescript): Allow for using compilerOptions.moduleResolution
#1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
approved these changes
Mar 12, 2023
tada5hi
approved these changes
Mar 20, 2023
shellscape
reviewed
Mar 20, 2023
This adds a test case for resolving types with node ESM `exports` feature and `compilerOptions.moduleResolution` option configured. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
fix/typescript-moduleresolution
branch
from
8ad0cd5
to
4bf49e9
Compare
RebeccaStevens
approved these changes
Apr 6, 2023
|
Anything I can help with to get this merged? |
|
Time is super short right now. Thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Align module resolution with the typescript compiler:
If
moduleResolutionis set it should be used and only if it is omitted the module setting might be considered.