feat(commonjs): Do not use getters for module.exports

[lukastaegert]

Rollup Plugin Name: commonjs

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

• Resolves TypeError when a dependency module depends upon Chalk - @rollup/plugin-commonjs > 23.0.4  #1446
• Resolves Broken ansi-styles produced by latest @rollup/plugin-commonjs rollup#4882

Description

This reactors the commons plugin to achieve two things:

• module is now again a simple object with an exports property and no getters and setters. This resolves issues when using Object.defineProperty on it.
• we still do not use syntheticNamedExports for this, which was an issue that I tried to fix earlier with the getters/setters

Furthermore, I made the __esModule detection logic more conservative so that we can be sure the detection helper is used whenever it is possible that an __esModule property might sneak in some way.

I checked the reproductions of both linked issues and can confirm that this change indeed fixes them.

[lukastaegert]

I published a beta release @rollup/plugin-commonjs@24.1.0-0 for easier testing.

[sapphi-red]

I tested out this PR with Vite. It passed the Vite's tests and I confirmed this fixes vitejs/vite#11986.

[shellscape]

@lukastaegert we'll need to revert the version change in packages/commonjs/package.json before merging

[lukastaegert]

we'll need to revert the version change in packages/commonjs/package.json before merging

@shellscape Oops, thanks for spotting, done!