fix(commonjs): change dynamicRequireRoot to normalizedDynamicRequireRoot && tweak related tests #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oot && tweak related tests
TrickyPi
force-pushed
the
fix/tweak
branch
2 times, most recently
from
6c16bf3
to
a26b00a
Compare
shellscape
requested review from
danielgindi,
guybedford,
NotWoods,
tjenkinson and
lukastaegert
9 tasks
|
Thanks for the PR. I added a few more reviewers. Someone with knowledge of the changes you made will have to approve. |
danielgindi
approved these changes
Jun 9, 2023
lukastaegert
approved these changes
Jun 10, 2023
|
I will merge this one now as it is a small change and unblocks #1507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
related #1461
resolves #1507
Description
This PR primary fix that the test failed in windows, see this action https://github.com/rollup/plugins/actions/runs/5104720044/jobs/9175831630?pr=1507 from #1507. By the way, I also change
dynamicRequireRoottonormalizedDynamicRequireRootfor unifying all the path value is normalized, but that also make a break change.