fix(typescript): change the value of isExternalLibraryImport to false if the resolvedModule should be compiled #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the resolvedModule should be compiled
shellscape
approved these changes
Jun 19, 2023
shellscape
requested review from
danielgindi,
guybedford,
NotWoods,
tjenkinson,
lukastaegert and
tada5hi
tada5hi
approved these changes
Jun 19, 2023
|
Could this PR be merged now? It already has two approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1520
Description
If the module's path contains 'node_modules', ts considers it an external library and refuses to compile it,
so we have to change the value of
isExternalLibraryImportto false if it's true