Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*)!: set min node engine version to v18 #1585

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tada5hi
Copy link
Member

@tada5hi tada5hi commented Sep 15, 2023

BREAKING CHANGE: min version changed

Rollup Plugin Name: {name}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

resolves #1580

Description

@shellscape
Copy link
Collaborator

got some CI issues there

@tada5hi
Copy link
Member Author

tada5hi commented Sep 29, 2023

It is so strange that the pnpm parallel execution in the ci fails...
On a local debian11 and windows10 machine the test runs even after clearing the cache.
image

@lukastaegert
Copy link
Member

I have a hope that it is a pnpm bug fixed in v8.7.6, will check tonight.

@tada5hi
Copy link
Member Author

tada5hi commented Oct 3, 2023

@lukastaegert i have that hope, too. I also think that in the pr #1595 it is the same problem.

@tada5hi
Copy link
Member Author

tada5hi commented Oct 5, 2023

@lukastaegert the --workspace-concurrency option, which i suggested for #1595 also solved the ci error here ^^. Maybe we can release this pr together with #1595

@tada5hi
Copy link
Member Author

tada5hi commented Oct 7, 2023

@shellscape i think this pr should be ready to merge.

@shellscape
Copy link
Collaborator

I'm going to be working on the CI system here this week, and one that allows a wildcard scope so that any affected package is published. We've had to include a bananas-long ass scope too many times now. Once that's done we can merge this. I'll keep you posted.

@tada5hi
Copy link
Member Author

tada5hi commented Oct 10, 2023

I'm going to be working on the CI system here this week, and one that allows a wildcard scope so that any affected package is published. We've had to include a bananas-long ass scope too many times now. Once that's done we can merge this. I'll keep you posted.

Sounds good! Maybe Lerna is an option. I use it for many projects and it is pretty awesome 😌

@shellscape
Copy link
Collaborator

shellscape commented Oct 10, 2023

Lerna is an absolute dumpster fire and the 2nd biggest pile of excrement for a devtool I've ever had the displeasure of using. It is only second to Nx in its awfulness. 😅

@shellscape
Copy link
Collaborator

Working on this today. Have an elegant solution in mind.

@shellscape
Copy link
Collaborator

Merged the update to the release pipeline but it needs an adjustment to account for the leading plugin- on the package names without the scopes. Will comment here once that's done. In the mean time, we should hold off on releasing anything. Should have that fixed this evening.

@shellscape
Copy link
Collaborator

OK we're good to go

@shellscape shellscape changed the title feat(repo)!: set min node engine version to v18 feat(*)!: set min node engine version to v18 Oct 29, 2023
@shellscape
Copy link
Collaborator

@tada5hi please update your branch from upstream/master

@tada5hi
Copy link
Member Author

tada5hi commented Oct 29, 2023

@shellscape i rebased the branch, but there seems to be an issue with the changed pr title.

@shellscape
Copy link
Collaborator

I fixed that on master. We'll bypass that. Will pull the trigger on this tomorrow after noon ET when I can babysit releasing the freaking world 😅

@tada5hi
Copy link
Member Author

tada5hi commented Oct 31, 2023

should i rebase it again ?

@shellscape
Copy link
Collaborator

We've got this #1618 PR for commonjs open which is going to be a breaking change/major, so I'd like to hold off just a bit on this one until we can get that resolved. I'll be trying to squeeze that change in without a release so we only get one major release for commonjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node v16 EOL
3 participants