New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commonjs)!: default strictRequires to true #1639
Open
bluwy
wants to merge
13
commits into
rollup:master
Choose a base branch
from
bluwy:commonjs-strict-requires-true
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 161d44f - Browse repository at this point
Copy the full SHA 161d44fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a91635 - Browse repository at this point
Copy the full SHA 1a91635View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0169dfc - Browse repository at this point
Copy the full SHA 0169dfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbf1c8e - Browse repository at this point
Copy the full SHA dbf1c8eView commit details -
While the error message has a different variable name, the point of the test is that we get an error.
Configuration menu - View commit details
-
Copy full SHA for 00fabc0 - Browse repository at this point
Copy the full SHA 00fabc0View commit details -
test: correctly pass options in test
Unfortunately, I did not find a way to detect this case from the plugin and show a warning.
Configuration menu - View commit details
-
Copy full SHA for 3121646 - Browse repository at this point
Copy the full SHA 3121646View commit details -
fix(commonjs): respect defaultIsModuleExports:false for ES imports fr…
…om wrapped CommonJS
Configuration menu - View commit details
-
Copy full SHA for b4a45b4 - Browse repository at this point
Copy the full SHA b4a45b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e08617 - Browse repository at this point
Copy the full SHA 0e08617View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03beb54 - Browse repository at this point
Copy the full SHA 03beb54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d2eac5 - Browse repository at this point
Copy the full SHA 9d2eac5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d80912e - Browse repository at this point
Copy the full SHA d80912eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccdf1c5 - Browse repository at this point
Copy the full SHA ccdf1c5View commit details -
fix(commonjs): treat moduleSideEffects as __PURE__ comments for proxi…
…ed wrapped modules
Configuration menu - View commit details
-
Copy full SHA for 3d78403 - Browse repository at this point
Copy the full SHA 3d78403View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.