Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): Ensure rollup 4 compatibility #1658

Merged
merged 1 commit into from Jan 9, 2024

Conversation

NiGhTTraX
Copy link
Contributor

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Existing v3 setup:

  1. repo has rollup@3 installed
  2. repo has @rollup/plugin-typescript@11.1.0 installed which peer depends on rollup@3
  3. @rollup/plugin-typescript@11.1.0 depends on @rollup/pluginutils@^5.0.1
  4. @rollup/pluginutils@5.0.2 is resolved and saved in the lockfile

Trying to upgrade to v4:

  1. upgrade to rollup@4 and @rollup/plugin-typescript@11.1.5 which peer depends on rollup@4
  2. @rollup/plugin-typescript@11.1.5 still depends on @rollup/pluginutils@^5.0.1
  3. @rollup/pluginutils@5.0.2 is not upgraded because it still matches
  4. @rollup/pluginutils@5.0.2 doesn't peer depend on rollup@4
  5. upgrade fails

This PR bumps the pluginutils dependency to ^5.1.0 which is the earliest version that peer depends on rollup@4.

There are a bunch more errors like this throughout the whole repo, but I'm only fixing this one for now. It's unfortunate that it ended up this way and pnpm install happily passes. I opened pnpm/pnpm#6893 a while ago to report this behaviour.

@shellscape shellscape merged commit db2cf23 into rollup:master Jan 9, 2024
5 checks passed
@shellscape
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants