Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing export type for esm-shim #1670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huozhi
Copy link
Contributor

@huozhi huozhi commented Feb 2, 2024

Rollup Plugin Name: esm-shim

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

There's a provideCJSSyntax method exported from es-shim plugin but it's not typed, adding the method type to esm-shim plugin's type file

@huozhi huozhi requested a review from tada5hi as a code owner February 2, 2024 17:50
@huozhi huozhi changed the title types: fix missing export type for esm-shim fix: fix missing export type for esm-shim Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant