Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-resolve): allow preferBuiltins to be a function #1694

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

younggglcy
Copy link
Contributor

Rollup Plugin Name: @rollup/plugin-node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: resolves #1655

Description

I think #1665 proposes a nice feature that gives preferBuiltins a more fine-grained control, so I'm trying to resolve this a little inactive issue.

This PR only makes node-resolve accept a function parameter to preferBuiltins to introduce as little as possible without changing the changes of the existing API.

#1665 also proposes that let it match the behavior of the external config of rollup. But I think in most cases, we only need to mark some modules as non-builtins, e.g., deprecated modules like punycode. And this is somehow contrary to the behavior of the external.

Is accepting a function enough or should we add some extra configs? I'm willing to contribute if we need to make more changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-resolve: allow more granular config of preferBuiltins
1 participant