Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-resolve): Fix bug where JS import was converted to a TS import, resulting in an error when using export maps #921

Merged
merged 22 commits into from Jul 24, 2021
Merged

fix(node-resolve): Fix bug where JS import was converted to a TS import, resulting in an error when using export maps #921

merged 22 commits into from Jul 24, 2021

Commits on Jul 1, 2021

  1. add fixture for importing js file from ts with export maps

    @tjenkinson
    tjenkinson committed Jul 1, 2021
    Copy the full SHA
    cf1fd99 View commit details
    Browse the repository at this point in the history

  2. always return null from resolveId if file not found 

    so that other candidates in `importSpecifierList` can be tried
    @tjenkinson
    tjenkinson committed Jul 1, 2021
    Copy the full SHA
    5a5188e View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2021

  1. fix invalid InvalidModuleSpecifierError call

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    7997de0 View commit details
    Browse the repository at this point in the history

  2. add resolveSymlink helper

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    262e5b0 View commit details
    Browse the repository at this point in the history

  3. shuffle importSpecifierList order so that the original import has t… 

    …op priority

and with a later commit will be the only one that export maps are tried on
    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    e773c26 View commit details
    Browse the repository at this point in the history

  4. refactor resolveImportSpecifiers to separate classic and exports al… 

    …gorithm

and to try the exports algorithm first, and only with the first id
    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    63f06e8 View commit details
    Browse the repository at this point in the history

  5. use correct function 

    mixup from having multiple branches
    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    0b77c51 View commit details
    Browse the repository at this point in the history

  6. remove TODO

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    fbe68fe View commit details
    Browse the repository at this point in the history

  7. update doc for resolveImportSpecifiers

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    5bd737d View commit details
    Browse the repository at this point in the history

  8. if export map algo fails with an error, do not fallback

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    ba26dbc View commit details
    Browse the repository at this point in the history

  9. if export map algo fails with an error, do not fallback (use exception)

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    4ca8cd1 View commit details
    Browse the repository at this point in the history

  10. test that we do not fallback to standard node algo on exports algo error

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    9ad1e75 View commit details
    Browse the repository at this point in the history

  11. make the test work everywhere

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    c3c84cb View commit details
    Browse the repository at this point in the history

  12. revert snapshot change

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    f275610 View commit details
    Browse the repository at this point in the history

  13. update test to point directly at entrypoint file

    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    bbc4a44 View commit details
    Browse the repository at this point in the history

  14. also try all import specifiers with exports algo 

    but the first one that supports exports, but had an error, will result in an error
    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    7730f36 View commit details
    Browse the repository at this point in the history

  15. Revert "also try all import specifiers with exports algo" 

    This reverts commit 7730f36.
    @tjenkinson
    tjenkinson committed Jul 4, 2021
    Copy the full SHA
    1875282 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Merge branch 'master' into resolve-fix-js-import-from-ts-with-export-map

    @tjenkinson
    tjenkinson committed Jul 24, 2021
    Copy the full SHA
    3e834ee View commit details
    Browse the repository at this point in the history

  2. run prettier

    @tjenkinson
    tjenkinson committed Jul 24, 2021
    Copy the full SHA
    5c67e64 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into resolve-fix-js-import-from-ts-with-export-map

    @tjenkinson
    tjenkinson committed Jul 24, 2021
    Copy the full SHA
    0bbc684 View commit details
    Browse the repository at this point in the history

  4. lint

    @tjenkinson
    tjenkinson committed Jul 24, 2021
    Copy the full SHA
    6e6b906 View commit details
    Browse the repository at this point in the history

  5. update test to make sure js import isn't written to .ts if js exists

    @tjenkinson
    tjenkinson committed Jul 24, 2021
    Copy the full SHA
    2e731b3 View commit details
    Browse the repository at this point in the history