chore: add eslint as a dependency #928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been procrastinating like a MF'er on the greater eslint alignment effort, and for that I apologize. I don't think we need this PR and that the original effort will solve this need. I'll do my best to make that happen in the next few days. |
|
Ah ok no worries I'll close this one then. I spotted this when I noticed the eslint bug in #927, meaning we'll have to update at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
allThis PR contains:
Are tests included?
Breaking Changes?
Description
I can't see
eslintlisted as a dependency anywhere so I think it exists as a side effect at the moment?