Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Fix alias discrepancy with Webpack #64

Merged
merged 2 commits into from Oct 21, 2019
Merged

Fix alias discrepancy with Webpack #64

merged 2 commits into from Oct 21, 2019

Conversation

jerriclynsjohn
Copy link
Contributor

Fixing the discrepancy of alias functionality of adding index.{ext} if the alias is a folder as mentioned in the issue #63

lukastaegert
lukastaegert approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to me, not necessarily because of the Webpack compatibility but because of the Node/Typescript compatibility.

@lukastaegert lukastaegert merged commit 38121ad into rollup:master Oct 21, 2019
@ifiri ifiri mentioned this pull request Nov 15, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@wesleygrimes wesleygrimes Awaiting requested review from wesleygrimes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerriclynsjohn @lukastaegert @shellscape