Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Treat sideEffects array as inclusion list #227

Merged
merged 4 commits into from
Jun 22, 2019
Merged

Treat sideEffects array as inclusion list #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91107fe
Treat sideEffects array as inclusion list
mikeharder Jun 20, 2019
d999d13
Rename 'true-index' to 'array-index' for clarity
mikeharder Jun 20, 2019
f05d925
Inline unnecessary local variable
mikeharder Jun 21, 2019
3d6c65e
Rename test files from "-free" to "-effect"
mikeharder Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ export default function nodeResolve ( options = {} ) {
if (typeof packageSideEffects === 'boolean') {
packageInfo.hasModuleSideEffects = () => packageSideEffects;
} else if (Array.isArray(packageSideEffects)) {
const filter = createFilter(packageSideEffects, null, {resolve: pkgRoot});
packageInfo.hasModuleSideEffects = id => !filter(id);
packageInfo.hasModuleSideEffects = createFilter(packageSideEffects, null, {resolve: pkgRoot});
}

packageInfoCache.set(pkgPath, packageInfo);
Expand Down
0 ...e_modules/side-effects-array/dep3-free.js → ...modules/side-effects-array/dep3-effect.js
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions test/node_modules/side-effects-array/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...es/side-effects-array/nested/dep5-free.js → .../side-effects-array/nested/dep5-effect.js
View file
Open in desktop
File renamed without changes.
3 changes: 2 additions & 1 deletion test/node_modules/side-effects-array/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,9 +890,10 @@ describe( 'rollup-plugin-node-resolve', function () {
'true-dep1',
'true-dep2',
'true-index',
'array-dep2',
'array-dep4',
'true-index'
'array-dep1',
'array-dep3',
'array-dep5',
'array-index'
]);
delete global.sideEffects;
}));
Expand Down