This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Add __read and __spread for ES5 downLevelIteration option #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
downLevelIteration
branch
from
92ec3cc
to
bd89458
Compare
eventualbuddha
force-pushed
the
downLevelIteration
branch
from
bd89458
to
bb2565c
Compare
|
I rebased this after merging #103 so the AppVeyor tests wouldn't be sitting there all red making everyone sad. As for the PR itself, I'm curious to know what fails without this. Could you add a test that would fail with the current release? |
|
Thanks for the quick response Brian! To get this running requires updating to TypeScript 2 in this repo. Also thinking a bit more about this though, I don't actually think it's necessary for Rollup. Comment here - rollup/rollup#1806 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to get the full ES5 support for the Rollup TypeScript conversion, otherwise we will still be relying on native iterators.
This could possibly be behind a flag in the plugin, just let me know thoughts here.