Slightly improve performance

rollup · Mar 23, 2020 · 23fabd2 · 23fabd2
1 parent 096f224
commit 23fabd2
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 18 deletions.
diff --git a/src/Chunk.ts b/src/Chunk.ts
@@ -457,19 +457,18 @@ export default class Chunk {
 			let renderedLength = 0;
 			if (module.isIncluded()) {
 				const source = module.render(renderOptions).trim();
-				if (options.compact && source.lastLine().indexOf('//') !== -1) source.append('\n');
-				const namespace = module.getOrCreateNamespace();
-				if (namespace.included || source.length() > 0) {
-					renderedLength = source.length();
+				renderedLength = source.length();
+				if (renderedLength) {
+					if (options.compact && source.lastLine().indexOf('//') !== -1) source.append('\n');
 					this.renderedModuleSources.set(module, source);
 					magicString.addSource(source);
 					this.usedModules.push(module);
-
-					if (namespace.included && !this.graph.preserveModules) {
-						const rendered = namespace.renderBlock(renderOptions);
-						if (namespace.renderFirst()) hoistedSource += n + rendered;
-						else magicString.addSource(new MagicString(rendered));
-					}
+				}
+				const namespace = module.getOrCreateNamespace();
+				if (namespace.included && !this.graph.preserveModules) {
+					const rendered = namespace.renderBlock(renderOptions);
+					if (namespace.renderFirst()) hoistedSource += n + rendered;
+					else magicString.addSource(new MagicString(rendered));
 				}
 			}
 			const { renderedExports, removedExports } = module.getRenderedExports();

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/amd/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/amd/generated-m1.js
@@ -1,7 +1,5 @@
 define(['exports', './m2'], function (exports, m2) { 'use strict';
 
-
-
 	var ms = /*#__PURE__*/Object.freeze({
 		__proto__: null,
 		m2: m2

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/cjs/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/cjs/generated-m1.js
@@ -2,8 +2,6 @@
 
 var m2 = require('./m2.js');
 
-
-
 var ms = /*#__PURE__*/Object.freeze({
 	__proto__: null,
 	m2: m2

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/es/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/es/generated-m1.js
@@ -1,7 +1,6 @@
 import m2 from './m2.js';
-export { default as a } from './m2.js';
-
 
+export { default as a } from './m2.js';
 
 var ms = /*#__PURE__*/Object.freeze({
 	__proto__: null,

diff --git a/test/chunking-form/samples/entry-point-without-own-code/_expected/system/generated-m1.js b/test/chunking-form/samples/entry-point-without-own-code/_expected/system/generated-m1.js
@@ -8,8 +8,6 @@ System.register(['./m2.js'], function (exports) {
 		}],
 		execute: function () {
 
-
-
 			var ms = /*#__PURE__*/Object.freeze({
 				__proto__: null,
 				m2: m2