Skip to content

Commit

Permalink
Properly construct namespace when dynamically importing chunks with f…
Browse files Browse the repository at this point in the history
…acades in default export mode (#3709)
  • Loading branch information
lukastaegert committed Aug 7, 2020
1 parent cd47fcf commit 3cb3c56
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/Chunk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,10 @@ export default class Chunk {
if (chunk === this) {
node.setInternalResolution(resolution.namespace);
} else {
node.setExternalResolution(chunk!.exportMode, resolution);
node.setExternalResolution(
this.facadeChunkByModule.get(resolution)?.exportMode || chunk!.exportMode,
resolution
);
}
} else {
node.setExternalResolution('auto', resolution);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const assert = require('assert');

module.exports = {
description: 'handles dynamic imports from facades using default export mode',
options: {
input: ['main', 'foo', 'bar']
},
exports(exports) {
return exports.then(exported => assert.deepStrictEqual(exported, { default: 4 }));
}
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import foo from './foo.js';
import square from './square.js';
export default square(3) + foo;
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
import square from './square.js';
export default square(2);
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default import('./foo.js');
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default x => x * x;

0 comments on commit 3cb3c56

Please sign in to comment.