Improve coverage

cli/run/index.ts

@@ -16,7 +16,7 @@ export default function runRollup(command: any) {
 		if (command.input) {
 			handleError({
 				code: 'DUPLICATE_IMPORT_OPTIONS',
-				message: 'use --input, or pass input path as argument'
+				message: 'Either use --input, or pass input path as argument'
 			});
 		}
 		inputSource = command._;

src/utils/parseOptions.ts

@@ -43,7 +43,7 @@ const getObjectOption = (
 	const commandOption = normalizeObjectOptionValue(overrides[name]);
 	const configOption = normalizeObjectOptionValue(config[name]);
 	if (commandOption !== undefined) {
-		return commandOption && configOption ? { ...configOption, ...commandOption } : commandOption;
+		return commandOption && { ...configOption, ...commandOption };
 	}
 	return configOption;
 };

test/cli/samples/duplicate-import-options/_config.js

@@ -0,0 +1,10 @@
+const { assertStderrIncludes } = require('../../../utils.js');
+
+module.exports = {
+	description: 'throws if different types of entries are combined',
+	command: 'rollup main.js --format es --input main.js',
+	error: () => true,
+	stderr(stderr) {
+		assertStderrIncludes(stderr, '[!] Either use --input, or pass input path as argument');
+	}
+};

test/cli/samples/duplicate-import-options/main.js

@@ -0,0 +1 @@
+assert.equal( 1 + 1, 2 );

test/cli/samples/external-modules-auto-global/_config.js

@@ -1,5 +1,11 @@
+const assert = require('assert');
+
 module.exports = {
 	description: 'populates options.external with --global keys',
-	command: 'rollup main.js --format iife --globals mathematics:Math',
-	execute: true
+	command:
+		'rollup main.js --format iife --globals mathematics:Math,promises:Promise --external promises',
+	execute: true,
+	stderr(stderr) {
+		assert.strictEqual(stderr.indexOf('(!)'), -1);
+	}
 };

test/cli/samples/external-modules-auto-global/main.js

@@ -1,3 +1,5 @@
 import { max } from 'mathematics';
+import { resolve } from 'promises';
 
 assert.equal( max( 1, 2, 3 ), 3 );
+assert.ok( resolve().then );

test/cli/samples/external-modules/_config.js

@@ -1,5 +1,10 @@
+const assert = require('assert');
+
 module.exports = {
 	description: 'allows external modules to be specified with --external=foo,bar,baz',
-	command: 'rollup main.js --format cjs --external path,util',
-	execute: true
+	command: 'rollup main.js --format cjs --external=path,util',
+	execute: true,
+	stderr(stderr) {
+		assert.strictEqual(stderr.indexOf('(!)'), -1);
+	}
 };

test/cli/samples/node-config-auto-prefix/_config.js

@@ -1,5 +1,5 @@
 module.exports = {
-	description: 'uses config file installed from npm',
+	description: 'uses config file installed from npm, automatically adding a rollup-config- prefix',
 	command: 'rollup --config node:foo',
 	execute: true
 };

test/cli/samples/node-config-not-found/_config.js

@@ -0,0 +1,10 @@
+const { assertStderrIncludes } = require('../../../utils.js');
+
+module.exports = {
+	description: 'throws if a config in node_modules cannot be found',
+	command: 'rollup --config node:baz',
+	error: () => true,
+	stderr(stderr) {
+		assertStderrIncludes(stderr, '[!] Could not resolve config file node:baz');
+	}
+};

test/cli/samples/node-config-not-found/_expected.js

@@ -0,0 +1,11 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
+	typeof define === 'function' && define.amd ? define(factory) :
+	global.myBundle = factory();
+}(this, function () { 'use strict';
+
+	var main = 42;
+
+	return main;
+
+}));

test/cli/samples/node-config-not-found/main.js

@@ -0,0 +1 @@
+assert.equal( ANSWER, 42 );

test/cli/samples/node-config/_config.js

@@ -1,6 +1,6 @@
 module.exports = {
 	description: 'uses config file installed from npm',
-	command: 'rollup --config node:foo',
+	command: 'rollup --config node:bar',
 	cwd: __dirname,
 	execute: true
 };