workaround for various object literal mutation bugs (#3266)

* Workaround for various object literal mutation bugs.

Some necessary minor regressions related to previously
unsafe object literal optimizations.

fixes #2345
fixes #2473
fixes #3027
fixes #3093
fixes #3192
fixes #3264

* Remove special logic to handle deoptimizing properties, always deopt `this` by default

src/ast/nodes/CallExpression.ts

@@ -17,6 +17,7 @@ import {
 } from '../utils/PathTracker';
 import { LiteralValueOrUnknown, UNKNOWN_EXPRESSION, UnknownValue } from '../values';
 import Identifier from './Identifier';
+import MemberExpression from './MemberExpression';
 import * as NodeType from './NodeType';
 import { ExpressionEntity } from './shared/Expression';
 import { ExpressionNode, INCLUDE_PARAMETERS, IncludeChildren, NodeBase } from './shared/Node';
@@ -66,6 +67,9 @@ export default class CallExpression extends NodeBase implements DeoptimizableEnt
 				this
 			);
 		}
+		if (this.callee instanceof MemberExpression && !this.callee.variable) {
+			this.callee.object.deoptimizePath(UNKNOWN_PATH);
+		}
 		for (const argument of this.arguments) {
 			// This will make sure all properties of parameters behave as "unknown"
 			argument.deoptimizePath(UNKNOWN_PATH);

test/form/samples/arrow-function-return-values/_expected.js

@@ -6,5 +6,9 @@ retained1()();
 (() => {
 	return () => console.log( 'effect' );
 })()();
+
+(() => ({ foo: () => {} }))().foo();
 (() => ({ foo: () => console.log( 'effect' ) }))().foo();
+
+(() => ({ foo: () => ({ bar: () => ({ baz: () => {} }) }) }))().foo().bar().baz();
 (() => ({ foo: () => ({ bar: () => console.log( 'effect' ) }) }))().foo().bar();

test/form/samples/builtin-prototypes/object-expression/_expected.js

@@ -1 +1,11 @@
+const object = {};
+const propertyIsEnumerable1 = object.propertyIsEnumerable( 'toString' );
+const propertyIsEnumerable2 = {}.propertyIsEnumerable( 'toString' );
+const propertyIsEnumerable3 = {}.propertyIsEnumerable( 'toString' ).valueOf();
 
+const _hasOwnProperty = {}.hasOwnProperty( 'toString' ).valueOf();
+const _isPrototypeOf = {}.isPrototypeOf( {} ).valueOf();
+const _propertyIsEnumerable = {}.propertyIsEnumerable( 'toString' ).valueOf();
+const _toLocaleString = {}.toLocaleString().trim();
+const _toString = {}.toString().trim();
+const _valueOf = {}.valueOf();

test/form/samples/conditional-expression-paths/_expected.js

@@ -1,11 +1,22 @@
 var unknownValue = globalThis.unknown();
 var foo = { x: () => {}, y: {} };
+var bar = { x: () => {}, y: {} };
 var baz = { x: () => console.log('effect') };
 
+// unknown branch without side-effects
+var a1 = (unknownValue ? foo : bar).y.z;
+var b1 = (unknownValue ? foo : bar).x();
+
 // unknown branch with side-effect
 var a2 = (unknownValue ? foo : baz).y.z;
 var b2 = (unknownValue ? foo : baz).x();
 
+// known branch without side-effects
+var a3 = ( foo ).y.z;
+var b3 = ( foo).y.z;
+var c3 = ( foo ).x();
+var d3 = ( foo).x();
+
 // known branch with side-effect
 var a4 = ( baz ).y.z;
 var b4 = ( baz).y.z;

test/form/samples/function-body-return-values/_expected.js

@@ -1,3 +1,9 @@
+function removed3 () {
+	return { x: () => {} };
+}
+
+removed3().x();
+
 function retained1 () {
 	return () => console.log( 'effect' );
 }

test/form/samples/getter-return-values/_expected/cjs.js → test/form/samples/getter-return-values/_expected.js

@@ -1,5 +1,3 @@
-'use strict';
-
 ({
 	get foo () {
 		console.log( 'effect' );
@@ -11,6 +9,12 @@
 		return {};
 	}
 }).foo.bar.baz;
+
+({
+	get foo () {
+		return () => {};
+	}
+}).foo();
 ({
 	get foo () {
 		console.log( 'effect' );
@@ -22,6 +26,12 @@
 		return () => console.log( 'effect' );
 	}
 }).foo();
+
+({
+	get foo () {
+		return () => () => {};
+	}
+}).foo()();
 ({
 	get foo () {
 		console.log( 'effect' );

test/form/samples/object-expression/method-side-effects/_expected.js

@@ -1,3 +1,12 @@
+const x = {
+	[globalThis.unknown]() {
+		console.log('effect');
+	},
+	a() {}
+};
+
+x.a();
+
 const y = {
 	a() {},
 	[globalThis.unknown]() {
@@ -12,3 +21,4 @@ const z = {
 };
 
 z.a();
+z.hasOwnProperty('a'); // removed

test/form/samples/object-expression/return-expressions/_expected.js

@@ -1,3 +1,10 @@
+const x = {
+	[globalThis.unknown]: () => () => console.log('effect'),
+	a: () => () => {}
+};
+
+x.a()();
+
 const y = {
 	a: () => () => {},
 	[globalThis.unknown]: () => () => console.log('effect')
@@ -12,6 +19,8 @@ const z = {
 z.a()();
 
 const v = {};
+
+v.toString().charCodeAt(0); // removed
 v.toString().doesNotExist(0); // retained
 
 const w = {

test/form/samples/object-literal-property-overwrites/_expected.js

@@ -1,3 +1,23 @@
+const removed1 = {
+	foo: () => {},
+	foo: () => {},
+	['f' + 'oo']: () => {}
+};
+removed1.foo();
+
+const removed2 = {
+	foo: () => console.log( 'effect' ),
+	foo: () => {}
+};
+removed2.foo();
+
+const removed3 = {
+	['fo' + 'o']: function () {this.x = 1;},
+	['f' + 'oo']: () => console.log( 'effect' ),
+	foo: () => {}
+};
+removed3.foo();
+
 const retained1 = {
 	foo: () => {},
 	foo: function () {this.x = 1;}

test/form/samples/property-setters-and-getters/early-access-getter-return/_expected.js

@@ -1,7 +1,16 @@
 function getReturnExpressionBeforeInit() {
-	{
+	const bar = {
+		[foo.value()]: true
+	};
+	if (bar.baz) {
 		console.log('retained');
 	}
 }
 
+const foo = {
+	get value() {
+		return () => 'baz';
+	}
+};
+
 getReturnExpressionBeforeInit();