Change default for output.generatedCode.reservedNamesAsProps

docs/999-big-list-of-options.md

@@ -560,7 +560,7 @@ export default {
 };
 ```
 
-**output.generatedCode.reservedNamesAsProps**<br> Type: `boolean`<br> CLI: `--generatedCode.reservedNamesAsProps`/`--no-generatedCode.reservedNamesAsProps`<br> Default: `false`
+**output.generatedCode.reservedNamesAsProps**<br> Type: `boolean`<br> CLI: `--generatedCode.reservedNamesAsProps`/`--no-generatedCode.reservedNamesAsProps`<br> Default: `true`
 
 Determine whether reserved words like "default" can be used as prop names without using quotes. This will make the syntax of the generated code ES3 compliant. Note however that for full ES3 compliance, you may also need to polyfill some builtin functions like `Object.keys` or `Array.prototype.forEach`.
 

src/Bundle.ts

@@ -44,7 +44,6 @@ export default class Bundle {
 		const outputBundle: OutputBundleWithPlaceholders = Object.create(null);
 		this.pluginDriver.setOutputBundle(outputBundle, this.outputOptions);
 
-		// TODO Lukas rethink time measuring points
 		try {
 			await this.pluginDriver.hookParallel('renderStart', [this.outputOptions, this.inputOptions]);
 

src/Chunk.ts

@@ -605,8 +605,6 @@ export default class Chunk {
 			renderedExports.length !== 0 ||
 			renderedDependencies.some(dep => (dep.reexports && dep.reexports.length !== 0)!);
 
-		// TODO Lukas Note: Mention in docs, that users/plugins are responsible to do their own caching
-		// TODO Lukas adapt plugin hook graphs and order in docs
 		const { intro, outro, banner, footer } = await createAddons(
 			outputOptions,
 			pluginDriver,

src/utils/options/normalizeOutputOptions.ts

@@ -359,7 +359,7 @@ const getGeneratedCode = (
 		arrowFunctions: configWithPreset.arrowFunctions === true,
 		constBindings: configWithPreset.constBindings === true || preferConst,
 		objectShorthand: configWithPreset.objectShorthand === true,
-		reservedNamesAsProps: configWithPreset.reservedNamesAsProps === true,
+		reservedNamesAsProps: configWithPreset.reservedNamesAsProps !== false,
 		symbols: configWithPreset.symbols === true
 	};
 };

test/chunking-form/samples/avoid-chunk-import-hoisting/_expected/amd/generated-dep.js

@@ -1,10 +1,10 @@
 define(['exports', 'lib'], (function (exports, value) { 'use strict';
 
-	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 	var value__default = /*#__PURE__*/_interopDefaultLegacy(value);
 
-	var dep = 2 * value__default["default"];
+	var dep = 2 * value__default.default;
 
 	exports.dep = dep;
 

test/chunking-form/samples/avoid-chunk-import-hoisting/_expected/cjs/generated-dep.js

@@ -2,10 +2,10 @@
 
 var value = require('lib');
 
-function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 var value__default = /*#__PURE__*/_interopDefaultLegacy(value);
 
-var dep = 2 * value__default["default"];
+var dep = 2 * value__default.default;
 
 exports.dep = dep;

test/chunking-form/samples/avoid-chunk-import-hoisting/_expected/system/generated-dep.js

@@ -3,7 +3,7 @@ System.register(['lib'], (function (exports) {
 	var value;
 	return {
 		setters: [function (module) {
-			value = module["default"];
+			value = module.default;
 		}],
 		execute: (function () {
 

test/chunking-form/samples/chunking-star-external/_expected/system/main1.js

@@ -2,7 +2,7 @@ System.register(['starexternal1', 'external1', './generated-dep.js', 'starextern
 	'use strict';
 	var _starExcludes = {
 		main: 1,
-		'default': 1,
+		default: 1,
 		e: 1,
 		dep: 1
 	};

test/chunking-form/samples/chunking-star-external/_expected/system/main2.js

@@ -2,7 +2,7 @@ System.register(['./generated-dep.js', 'external2', 'starexternal2'], (function
 	'use strict';
 	var _starExcludes = {
 		main: 1,
-		'default': 1,
+		default: 1,
 		dep: 1,
 		e: 1
 	};

test/chunking-form/samples/default-reexport-namespace/_expected/system/main.js

@@ -3,7 +3,7 @@ System.register(['./one.js'], (function (exports) {
 	var __icon__$1;
 	return {
 		setters: [function (module) {
-			__icon__$1 = module["default"];
+			__icon__$1 = module.default;
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/dynamic-import-comments/_expected/amd/main.js

@@ -14,7 +14,7 @@ define(['require'], (function (require) { 'use strict';
 				}
 			});
 		}
-		n["default"] = e;
+		n.default = e;
 		return Object.freeze(n);
 	}
 

test/chunking-form/samples/deprecated/dynamic-import-comments/_expected/cjs/main.js

@@ -14,7 +14,7 @@ function _interopNamespace(e) {
 			}
 		});
 	}
-	n["default"] = e;
+	n.default = e;
 	return Object.freeze(n);
 }
 

test/chunking-form/samples/deprecated/dynamic-import-name/_expected/amd/main.js

@@ -14,7 +14,7 @@ define(['require'], (function (require) { 'use strict';
 				}
 			});
 		}
-		n["default"] = e;
+		n.default = e;
 		return Object.freeze(n);
 	}
 

test/chunking-form/samples/deprecated/dynamic-import-name/_expected/cjs/main.js

@@ -14,7 +14,7 @@ function _interopNamespace(e) {
 			}
 		});
 	}
-	n["default"] = e;
+	n.default = e;
 	return Object.freeze(n);
 }
 

test/chunking-form/samples/deprecated/indirect-reexports-preserve-modules/_expected/amd/components/index.js

@@ -1,6 +1,6 @@
 define(['exports', './sub/index'], (function (exports, index) { 'use strict';
 
-	const baz = { bar: index["default"] };
+	const baz = { bar: index.default };
 
 	exports.foo = index.foo;
 	exports.baz = baz;

test/chunking-form/samples/deprecated/indirect-reexports-preserve-modules/_expected/amd/components/sub/index.js

@@ -3,7 +3,7 @@ define(['exports'], (function (exports) { 'use strict';
 	const foo = 'bar';
 	var bar = () => {};
 
-	exports["default"] = bar;
+	exports.default = bar;
 	exports.foo = foo;
 
 	Object.defineProperty(exports, '__esModule', { value: true });

test/chunking-form/samples/deprecated/indirect-reexports-preserve-modules/_expected/cjs/components/index.js

@@ -4,7 +4,7 @@ Object.defineProperty(exports, '__esModule', { value: true });
 
 var index = require('./sub/index.js');
 
-const baz = { bar: index["default"] };
+const baz = { bar: index.default };
 
 exports.foo = index.foo;
 exports.baz = baz;

test/chunking-form/samples/deprecated/indirect-reexports-preserve-modules/_expected/cjs/components/sub/index.js

@@ -5,5 +5,5 @@ Object.defineProperty(exports, '__esModule', { value: true });
 const foo = 'bar';
 var bar = () => {};
 
-exports["default"] = bar;
+exports.default = bar;
 exports.foo = foo;

test/chunking-form/samples/deprecated/indirect-reexports-preserve-modules/_expected/system/components/index.js

@@ -3,7 +3,7 @@ System.register('bundle', ['./sub/index.js'], (function (exports) {
 	var bar;
 	return {
 		setters: [function (module) {
-			bar = module["default"];
+			bar = module.default;
 			exports('foo', module.foo);
 		}],
 		execute: (function () {

test/chunking-form/samples/deprecated/interop-per-reexported-default-dependency-boolean/_expected/amd/true.js

@@ -1,11 +1,11 @@
 define(['external-true'], (function (externalTrue) { 'use strict';
 
-	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 	var externalTrue__default = /*#__PURE__*/_interopDefaultLegacy(externalTrue);
 
 
 
-	return externalTrue__default["default"];
+	return externalTrue__default.default;
 
 }));

test/chunking-form/samples/deprecated/interop-per-reexported-default-dependency-boolean/_expected/cjs/true.js

@@ -2,10 +2,10 @@
 
 var externalTrue = require('external-true');
 
-function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 var externalTrue__default = /*#__PURE__*/_interopDefaultLegacy(externalTrue);
 
 
 
-module.exports = externalTrue__default["default"];
+module.exports = externalTrue__default.default;

test/chunking-form/samples/deprecated/interop-per-reexported-default-dependency-boolean/_expected/system/false.js

@@ -2,7 +2,7 @@ System.register(['external-false'], (function (exports) {
 	'use strict';
 	return {
 		setters: [function (module) {
-			exports('default', module["default"]);
+			exports('default', module.default);
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/interop-per-reexported-default-dependency-boolean/_expected/system/true.js

@@ -2,7 +2,7 @@ System.register(['external-true'], (function (exports) {
 	'use strict';
 	return {
 		setters: [function (module) {
-			exports('default', module["default"]);
+			exports('default', module.default);
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/namespace-tostring/dynamic-import-default-mode/_expected/amd/main.js

@@ -1,6 +1,6 @@
 define(['require'], (function (require) { 'use strict';
 
-	function _interopNamespaceDefaultOnly (e) { return Object.freeze(Object.defineProperty({ __proto__: null, 'default': e }, Symbol.toStringTag, { value: 'Module' })); }
+	function _interopNamespaceDefaultOnly (e) { return Object.freeze(Object.defineProperty({ __proto__: null, default: e }, Symbol.toStringTag, { value: 'Module' })); }
 
 	new Promise(function (resolve, reject) { require(['./foo'], function (m) { resolve(/*#__PURE__*/_interopNamespaceDefaultOnly(m)); }, reject); }).then(console.log);
 

test/chunking-form/samples/deprecated/namespace-tostring/dynamic-import-default-mode/_expected/cjs/main.js

@@ -1,5 +1,5 @@
 'use strict';
 
-function _interopNamespaceDefaultOnly (e) { return Object.freeze(Object.defineProperty({ __proto__: null, 'default': e }, Symbol.toStringTag, { value: 'Module' })); }
+function _interopNamespaceDefaultOnly (e) { return Object.freeze(Object.defineProperty({ __proto__: null, default: e }, Symbol.toStringTag, { value: 'Module' })); }
 
 Promise.resolve().then(function () { return /*#__PURE__*/_interopNamespaceDefaultOnly(require('./foo.js')); }).then(console.log);

test/chunking-form/samples/deprecated/preserve-modules-auto-export-mode/_expected/amd/main.js

@@ -1,6 +1,6 @@
 define(['require', './default', './named'], (function (require, _default, named) { 'use strict';
 
-	function _interopNamespaceDefaultOnly (e) { return Object.freeze({ __proto__: null, 'default': e }); }
+	function _interopNamespaceDefaultOnly (e) { return Object.freeze({ __proto__: null, default: e }); }
 
 	console.log(_default, named.value);
 

test/chunking-form/samples/deprecated/preserve-modules-auto-export-mode/_expected/cjs/main.js

@@ -3,7 +3,7 @@
 var _default = require('./default.js');
 var named = require('./named.js');
 
-function _interopNamespaceDefaultOnly (e) { return Object.freeze({ __proto__: null, 'default': e }); }
+function _interopNamespaceDefaultOnly (e) { return Object.freeze({ __proto__: null, default: e }); }
 
 console.log(_default, named.value);
 

test/chunking-form/samples/deprecated/preserve-modules-auto-export-mode/_expected/system/main.js

@@ -3,8 +3,8 @@ System.register(['./default.js', './named.js'], (function (exports, module) {
 	var foo, value;
 	return {
 		setters: [function (module) {
-			foo = module["default"];
-			exports('default', module["default"]);
+			foo = module.default;
+			exports('default', module.default);
 		}, function (module) {
 			value = module.value;
 		}],

test/chunking-form/samples/deprecated/preserve-modules-commonjs/_expected/amd/commonjs.js

@@ -1,10 +1,10 @@
 define(['external', './other', './_virtual/other'], (function (require$$0, other$1, other) { 'use strict';
 
-	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 	var require$$0__default = /*#__PURE__*/_interopDefaultLegacy(require$$0);
 
-	const external = require$$0__default["default"];
+	const external = require$$0__default.default;
 	const { value } = other.__exports;
 
 	console.log(external, value);

test/chunking-form/samples/deprecated/preserve-modules-commonjs/_expected/amd/main.js

@@ -1,9 +1,9 @@
 define(['./commonjs', 'external'], (function (commonjs, require$$0) { 'use strict';
 
-	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+	function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 	var require$$0__default = /*#__PURE__*/_interopDefaultLegacy(require$$0);
 
-	console.log(commonjs, require$$0__default["default"]);
+	console.log(commonjs, require$$0__default.default);
 
 }));

test/chunking-form/samples/deprecated/preserve-modules-commonjs/_expected/cjs/commonjs.js

@@ -4,11 +4,11 @@ var require$$0 = require('external');
 require('./other.js');
 var other = require('./_virtual/other.js');
 
-function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 var require$$0__default = /*#__PURE__*/_interopDefaultLegacy(require$$0);
 
-const external = require$$0__default["default"];
+const external = require$$0__default.default;
 const { value } = other.__exports;
 
 console.log(external, value);

test/chunking-form/samples/deprecated/preserve-modules-commonjs/_expected/cjs/main.js

@@ -3,8 +3,8 @@
 var commonjs = require('./commonjs.js');
 var require$$0 = require('external');
 
-function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
+function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 
 var require$$0__default = /*#__PURE__*/_interopDefaultLegacy(require$$0);
 
-console.log(commonjs, require$$0__default["default"]);
+console.log(commonjs, require$$0__default.default);

test/chunking-form/samples/deprecated/preserve-modules-commonjs/_expected/system/commonjs.js

@@ -3,7 +3,7 @@ System.register(['external', './other.js', './_virtual/other.js'], (function (ex
 	var require$$0, other;
 	return {
 		setters: [function (module) {
-			require$$0 = module["default"];
+			require$$0 = module.default;
 		}, function () {}, function (module) {
 			other = module.__exports;
 		}],

test/chunking-form/samples/deprecated/preserve-modules-commonjs/_expected/system/main.js

@@ -3,9 +3,9 @@ System.register(['./commonjs.js', 'external'], (function () {
 	var commonjs, require$$0;
 	return {
 		setters: [function (module) {
-			commonjs = module["default"];
+			commonjs = module.default;
 		}, function (module) {
-			require$$0 = module["default"];
+			require$$0 = module.default;
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/preserve-modules-dynamic-namespace/_expected/system/m1.js

@@ -2,9 +2,9 @@ System.register(['./m2.js', './m3.js'], (function (exports) {
 	'use strict';
 	return {
 		setters: [function (module) {
-			exports('m2', module["default"]);
+			exports('m2', module.default);
 		}, function (module) {
-			exports('m3', module["default"]);
+			exports('m3', module.default);
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/preserve-modules-empty/_expected/system/main.js

@@ -3,7 +3,7 @@ System.register(['./two.js'], (function () {
 	var a;
 	return {
 		setters: [function (module) {
-			a = module["default"];
+			a = module.default;
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/preserve-modules-filename-pattern/_expected/system/entry-main-system-ts.ts.js

@@ -2,13 +2,13 @@ System.register(['./entry-foo-system-ts.ts.js', './nested/entry-bar-system-ts.ts
 	'use strict';
 	return {
 		setters: [function (module) {
-			exports('foo', module["default"]);
+			exports('foo', module.default);
 		}, function (module) {
-			exports('bar', module["default"]);
+			exports('bar', module.default);
 		}, function (module) {
-			exports('baz', module["default"]);
+			exports('baz', module.default);
 		}, function (module) {
-			exports('noExt', module["default"]);
+			exports('noExt', module.default);
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/preserve-modules-id-case-sensitive/_expected/system/main.js

@@ -3,11 +3,11 @@ System.register(['./_virtual/_one.js', './_virtual/_One2.js', './_virtual/_One1.
 	var a, b, c;
 	return {
 		setters: [function (module) {
-			a = module["default"];
+			a = module.default;
 		}, function (module) {
-			b = module["default"];
+			b = module.default;
 		}, function (module) {
-			c = module["default"];
+			c = module.default;
 		}],
 		execute: (function () {
 

test/chunking-form/samples/deprecated/preserve-modules-named-export-mode/_expected/amd/default.js

@@ -2,7 +2,7 @@ define(['exports'], (function (exports) { 'use strict';
 
 	var foo = 'default';
 
-	exports["default"] = foo;
+	exports.default = foo;
 
 	Object.defineProperty(exports, '__esModule', { value: true });