Skip to content

Commit

Permalink
Only run tests on Node 10 and 12 as we want to do this anyway and cho…
Browse files Browse the repository at this point in the history
…kidar depends on utils.promisify
  • Loading branch information
lukastaegert committed Jan 12, 2020
1 parent eb49b5e commit 418bf21
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 40 deletions.
20 changes: 0 additions & 20 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ jobs:
key: dependency-cache-{{ checksum "package-lock.json" }}
paths:
- ./node_modules
node-v6-latest:
docker:
- image: rollupcabal/circleci-node-v6:latest
<<: *unit_tests
node-v8-latest:
docker:
- image: rollupcabal/circleci-node-v8:latest
<<: *unit_tests
node-v10-latest:
docker:
- image: rollupcabal/circleci-node-v10:latest
Expand All @@ -70,18 +62,6 @@ workflows:
filters:
tags:
only: /.*/
- node-v6-latest:
requires:
- analysis
filters:
tags:
only: /.*/
- node-v8-latest:
requires:
- analysis
filters:
tags:
only: /.*/
- node-v10-latest:
requires:
- analysis
Expand Down
39 changes: 19 additions & 20 deletions .github/workflows/node-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,29 @@ on: [push]

jobs:
build:

runs-on: windows-2019

strategy:
matrix:
node: [ '10', '6' ]
node: ['12', '10']

name: ${{ matrix.node }} (Windows)
steps:
- name: Configure git line-breaks
run: git config --global core.autocrlf false
- name: Checkout Commit
uses: actions/checkout@v1
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- name: Check npm version
# This is only necessary until we dump Node 6
run: if [ ${{ matrix.node }} -lt 8 ]; then npm i npm@5 -g; fi;
shell: bash
- name: Install dependencies
run: npm ci --ignore-scripts
- name: Run tests
run: npm test
env:
CI: true
- name: Configure git line-breaks
run: git config --global core.autocrlf false
- name: Checkout Commit
uses: actions/checkout@v1
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- name: Check npm version
# This is only necessary until we dump Node 6
run: if [ ${{ matrix.node }} -lt 8 ]; then npm i npm@5 -g; fi;
shell: bash
- name: Install dependencies
run: npm ci --ignore-scripts
- name: Run tests
run: npm test
env:
CI: true

0 comments on commit 418bf21

Please sign in to comment.