chore: improve types

rollup · Oct 14, 2022 · 4eb3e36 · 4eb3e36
1 parent 65d49f1
commit 4eb3e36
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/src/rollup/rollup.ts b/src/rollup/rollup.ts
@@ -203,7 +203,7 @@ async function getOutputOptionsAndPluginDriver(
 	};
 }
 
-async function getOutputOptions(
+function getOutputOptions(
 	inputOptions: NormalizedInputOptions,
 	unsetInputOptions: ReadonlySet<string>,
 	rawOutputOptions: OutputOptions,

diff --git a/src/rollup/types.d.ts b/src/rollup/types.d.ts
@@ -1,5 +1,9 @@
 export const VERSION: string;
 
+type FalsyValue = false | null | undefined;
+type MaybeArray<T> = T | T[];
+type MaybePromise<T> = T | Promise<T>;
+
 export interface RollupError extends RollupLog {
 	name?: string;
 	stack?: string;
@@ -495,13 +499,7 @@ export type SourcemapPathTransformOption = (
 	sourcemapPath: string
 ) => string;
 
-export type InputPluginOption =
-	| Plugin
-	| null
-	| false
-	| undefined
-	| InputPluginOption[]
-	| Promise<Plugin | false | null | undefined | InputPluginOption[]>;
+export type InputPluginOption = MaybePromise<Plugin | FalsyValue | InputPluginOption[]>;
 
 export interface InputOptions {
 	acorn?: Record<string, unknown>;
@@ -625,13 +623,7 @@ export type NormalizedAmdOptions = (
 
 type AddonFunction = (chunk: RenderedChunk) => string | Promise<string>;
 
-type OutputPluginOption =
-	| OutputPlugin
-	| null
-	| false
-	| undefined
-	| OutputPluginOption[]
-	| Promise<OutputPlugin | false | null | undefined | OutputPluginOption[]>;
+type OutputPluginOption = MaybePromise<OutputPlugin | FalsyValue | OutputPluginOption[]>;
 
 export interface OutputOptions {
 	amd?: AmdOptions;