Skip to content

Commit

Permalink
see if Node4 build can work without defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
guybedford committed Dec 23, 2017
1 parent 1073782 commit 697d677
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion bin/src/logging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ if (!process.stderr.isTTY) chalk.enabled = false;
// log to stderr to keep `rollup main.js > bundle.js` from breaking
export const stderr = console.error.bind(console); // eslint-disable-line no-console

export function handleError (err: RollupError, recover = false) {
export function handleError (err: RollupError, recover?: boolean) {
let description = err.message || err;
if (err.name) description = `${err.name}: ${description}`;
const message =
Expand Down
2 changes: 1 addition & 1 deletion bin/src/run/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { InputOptions, OutputOptions, OutputBundle } from '../../../src/rollup/i
import { BatchWarnings } from './batchWarnings';
import { SourceMap } from 'magic-string';

export default function build (inputOptions: InputOptions, outputOptions: OutputOptions[], warnings: BatchWarnings, silent = false) {
export default function build (inputOptions: InputOptions, outputOptions: OutputOptions[], warnings: BatchWarnings, silent?: boolean) {
const useStdout = outputOptions.length === 1 && !outputOptions[0].file;

const start = Date.now();
Expand Down
2 changes: 1 addition & 1 deletion bin/src/run/loadConfigFile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import relativeId from '../../../src/utils/relativeId.js';
import { handleError, stderr } from '../logging.js';
import { InputOptions, OutputBundle } from '../../../src/rollup/index';

export default function loadConfigFile (configFile: string, silent = false): Promise<InputOptions[]> {
export default function loadConfigFile (configFile: string, silent?: boolean): Promise<InputOptions[]> {
const warnings = batchWarnings();

return rollup
Expand Down
2 changes: 1 addition & 1 deletion bin/src/run/watch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ interface Watcher {
close: () => void;
};

export default function watch (configFile: string, configs: RollupWatchOptions[], command: any, silent = false) {
export default function watch (configFile: string, configs: RollupWatchOptions[], command: any, silent?: boolean) {
const isTTY = Boolean(process.stderr.isTTY);

const screen = alternateScreen(isTTY);
Expand Down

0 comments on commit 697d677

Please sign in to comment.