Watch: listen for new files added to a directory (#3812)

rollup · Oct 8, 2020 · 74e5081 · 74e5081
1 parent 929f0ac
commit 74e5081
Show file tree

Hide file tree

Showing 2 changed files with 90 additions and 0 deletions.
diff --git a/src/watch/fileWatcher.ts b/src/watch/fileWatcher.ts
@@ -58,6 +58,7 @@ export class FileWatcher {
 		};
 		const watcher = chokidar
 			.watch([], this.chokidarOptions)
+			.on('add', handleChange)
 			.on('change', handleChange)
 			.on('unlink', handleChange);
 		return watcher;

diff --git a/test/watch/index.js b/test/watch/index.js
@@ -1488,6 +1488,95 @@ describe('rollup.watch', () => {
 				});
 		});
 
+		it('respects initially missing added watched files', () => {
+			return sander
+				.copydir('test/watch/samples/basic')
+				.to('test/_tmp/input')
+				.then(() => {
+					watcher = rollup.watch({
+						input: 'test/_tmp/input/main.js',
+						output: {
+							file: 'test/_tmp/output/bundle.js',
+							format: 'cjs',
+							exports: 'auto'
+						},
+						plugins: {
+							transform() {
+								this.addWatchFile('test/_tmp/input/dep');
+								return `export default ${sander.existsSync('test/_tmp/input/dep')}`;
+							}
+						}
+					});
+
+					return sequence(watcher, [
+						'START',
+						'BUNDLE_START',
+						'BUNDLE_END',
+						'END',
+						() => {
+							assert.strictEqual(run('../_tmp/output/bundle.js'), false);
+							sander.writeFileSync('test/_tmp/input/dep', '');
+						},
+						'START',
+						'BUNDLE_START',
+						'BUNDLE_END',
+						'END',
+						() => {
+							assert.strictEqual(run('../_tmp/output/bundle.js'), true);
+						}
+					]);
+				});
+		});
+
+		it('respects unlinked and re-added watched files', () => {
+			return sander
+				.copydir('test/watch/samples/basic')
+				.to('test/_tmp/input')
+				.then(() => {
+					sander.writeFileSync('test/_tmp/input/dep', '');
+					watcher = rollup.watch({
+						input: 'test/_tmp/input/main.js',
+						output: {
+							file: 'test/_tmp/output/bundle.js',
+							format: 'cjs',
+							exports: 'auto'
+						},
+						plugins: {
+							transform() {
+								this.addWatchFile('test/_tmp/input/dep');
+								return `export default ${sander.existsSync('test/_tmp/input/dep')}`;
+							}
+						}
+					});
+
+					return sequence(watcher, [
+						'START',
+						'BUNDLE_START',
+						'BUNDLE_END',
+						'END',
+						() => {
+							assert.strictEqual(run('../_tmp/output/bundle.js'), true);
+							sander.unlinkSync('test/_tmp/input/dep');
+						},
+						'START',
+						'BUNDLE_START',
+						'BUNDLE_END',
+						'END',
+						() => {
+							assert.strictEqual(run('../_tmp/output/bundle.js'), false);
+							sander.writeFileSync('test/_tmp/input/dep', '');
+						},
+						'START',
+						'BUNDLE_START',
+						'BUNDLE_END',
+						'END',
+						() => {
+							assert.strictEqual(run('../_tmp/output/bundle.js'), true);
+						}
+					]);
+				});
+		});
+
 		it('does not rerun the transform hook if a non-watched change triggered the re-run', () => {
 			let transformRuns = 0;
 			return sander