Skip to content

Commit

Permalink
Improve coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
lukastaegert committed Oct 5, 2020
1 parent b9f2371 commit 88f0c6b
Show file tree
Hide file tree
Showing 12 changed files with 55 additions and 14 deletions.
10 changes: 4 additions & 6 deletions src/utils/transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,12 @@ export default function transform(
return pluginContext.error(err);
},
emitAsset(name: string, source?: string | Uint8Array) {
const emittedFile = { type: 'asset' as const, name, source };
emittedFiles.push({ ...emittedFile });
return pluginDriver.emitFile(emittedFile);
emittedFiles.push({ type: 'asset' as const, name, source });
return pluginContext.emitAsset(name, source);
},
emitChunk(id, options) {
const emittedFile = { type: 'chunk' as const, id, name: options && options.name };
emittedFiles.push({ ...emittedFile });
return pluginDriver.emitFile(emittedFile);
emittedFiles.push({ type: 'chunk' as const, id, name: options && options.name });
return pluginContext.emitChunk(id, options);
},
emitFile(emittedFile: EmittedFile) {
emittedFiles.push(emittedFile);
Expand Down
19 changes: 16 additions & 3 deletions test/chunking-form/samples/deprecated/emit-chunk-named/_config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const assert = require('assert');
let referenceId;
let referenceIdBuildStart;
let referenceIdTransform;

module.exports = {
description: 'allows naming emitted chunks',
Expand All @@ -9,10 +10,22 @@ module.exports = {
input: 'main',
plugins: {
buildStart() {
referenceId = this.emitChunk('buildStart', { name: 'nested/my-chunk' });
referenceIdBuildStart = this.emitChunk('buildStart', { name: 'nested/build-start' });
},
transform(code, id) {
if (id.endsWith('main.js')) {
referenceIdTransform = this.emitChunk('transform', { name: 'nested/transform' });
}
},
renderChunk() {
assert.strictEqual(this.getChunkFileName(referenceId), 'generated-nested/my-chunk.js');
assert.strictEqual(
this.getChunkFileName(referenceIdBuildStart),
'generated-nested/build-start.js'
);
assert.strictEqual(
this.getChunkFileName(referenceIdTransform),
'generated-nested/transform.js'
);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
define(['../generated-dep'], function (dep) { 'use strict';

console.log('startBuild', dep.value);
console.log('buildStart', dep.value);

});
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
define(['../generated-dep'], function (dep) { 'use strict';

console.log('transform', dep.value);

});
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

var dep = require('../generated-dep.js');

console.log('startBuild', dep.value);
console.log('buildStart', dep.value);
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

var dep = require('../generated-dep.js');

console.log('transform', dep.value);
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { v as value } from '../generated-dep.js';

console.log('startBuild', value);
console.log('buildStart', value);
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { v as value } from '../generated-dep.js';

console.log('transform', value);
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ System.register(['../generated-dep.js'], function () {
}],
execute: function () {

console.log('startBuild', value);
console.log('buildStart', value);

}
};
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
System.register(['../generated-dep.js'], function () {
'use strict';
var value;
return {
setters: [function (module) {
value = module.v;
}],
execute: function () {

console.log('transform', value);

}
};
});
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import value from './dep.js';

console.log('startBuild', value);
console.log('buildStart', value);
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import value from './dep.js';

console.log('transform', value);

0 comments on commit 88f0c6b

Please sign in to comment.