Properly quit on uncaught exceptions (#4987)

cli/run/watch-cli.ts

@@ -29,7 +29,7 @@ export async function watch(command: Record<string, any>): Promise<void> {
 	const runWatchHook = createWatchHooks(command);
 
 	onExit(close);
-	process.on('uncaughtException', close);
+	process.on('uncaughtException', closeWithError);
 	if (!process.stdin.isTTY) {
 		process.stdin.on('end', close);
 		process.stdin.resume();
@@ -147,7 +147,7 @@ export async function watch(command: Record<string, any>): Promise<void> {
 	}
 
 	async function close(code: number | null | undefined): Promise<void> {
-		process.removeListener('uncaughtException', close);
+		process.removeListener('uncaughtException', closeWithError);
 		// removing a non-existent listener is a no-op
 		process.stdin.removeListener('end', close);
 
@@ -160,3 +160,8 @@ export async function watch(command: Record<string, any>): Promise<void> {
 	// return a promise that never resolves to keep the process running
 	return new Promise(() => {});
 }
+
+function closeWithError(error: Error): void {
+	error.name = `Uncaught ${error.name}`;
+	handleError(error);
+}

test/cli/samples/handles-uncaught-errors/_config.js

@@ -0,0 +1,10 @@
+const { assertIncludes } = require('../../../utils.js');
+
+module.exports = defineTest({
+	description: 'handles uncaught errors',
+	command: 'rollup --config rollup.config.js',
+	error: () => true,
+	stderr(stderr) {
+		assertIncludes(stderr, 'TypeError: foo');
+	}
+});

test/cli/samples/handles-uncaught-errors/main.js

@@ -0,0 +1 @@
+assert.equal( 42, 42 );

test/cli/samples/handles-uncaught-errors/rollup.config.js

@@ -0,0 +1,16 @@
+module.exports = {
+	input: 'main.js',
+	output: {
+		format: 'cjs'
+	},
+	plugins: [
+		{
+			name: 'test',
+			buildStart() {
+				Promise.resolve().then(() => {
+					throw new TypeError('foo');
+				});
+			}
+		}
+	]
+};