Handle loading symlinked config files (#3783)

CHANGELOG.md

@@ -1,5 +1,14 @@
 # rollup changelog
 
+## 2.27.1
+*2020-09-17*
+
+### Bug Fixes
+* Do not fail when using ES module imports in symlinked config files (#3783)
+
+### Pull Requests
+* [#3783](https://github.com/rollup/rollup/pull/3783): Handle loading symlinked config files (@lukastaegert)
+
 ## 2.27.0
 *2020-09-16*
 

cli/run/getConfigPath.ts

@@ -1,14 +1,14 @@
-import { readdirSync, realpathSync } from 'fs';
+import { readdirSync } from 'fs';
 import * as path from 'path';
 import relative from 'require-relative';
 import { handleError } from '../logging';
 
 const DEFAULT_CONFIG_BASE = 'rollup.config';
 
-export function getConfigPath(commandConfig: any): string {
+export function getConfigPath(commandConfig: string | true): string {
 	const cwd = process.cwd();
 	if (commandConfig === true) {
-		return path.join(cwd, findConfigFileNameInCwd());
+		return path.resolve(findConfigFileNameInCwd());
 	}
 	if (commandConfig.slice(0, 5) === 'node:') {
 		const pkgName = commandConfig.slice(5);
@@ -28,7 +28,7 @@ export function getConfigPath(commandConfig: any): string {
 			}
 		}
 	}
-	return realpathSync(commandConfig);
+	return path.resolve(commandConfig);
 }
 
 function findConfigFileNameInCwd(): string {

cli/run/loadConfigFile.ts

@@ -1,4 +1,5 @@
 import { bold } from 'colorette';
+import * as fs from 'fs';
 import * as path from 'path';
 import { pathToFileURL } from 'url';
 import * as rollup from '../../src/node-entry';
@@ -82,16 +83,17 @@ async function getDefaultFromTranspiledConfigFile(
 }
 
 async function loadConfigFromBundledFile(fileName: string, bundledCode: string) {
-	const extension = path.extname(fileName);
+	const resolvedFileName = fs.realpathSync(fileName);
+	const extension = path.extname(resolvedFileName);
 	const defaultLoader = require.extensions[extension]!;
-	require.extensions[extension] = (module: NodeModule, filename: string) => {
-		if (filename === fileName) {
-			(module as NodeModuleWithCompile)._compile(bundledCode, filename);
+	require.extensions[extension] = (module: NodeModule, requiredFileName: string) => {
+		if (requiredFileName === resolvedFileName) {
+			(module as NodeModuleWithCompile)._compile(bundledCode, requiredFileName);
 		} else {
-			defaultLoader(module, filename);
+			defaultLoader(module, requiredFileName);
 		}
 	};
-	delete require.cache[fileName];
+	delete require.cache[resolvedFileName];
 	try {
 		const config = getDefaultFromCjs(require(fileName));
 		require.extensions[extension] = defaultLoader;

test/cli/samples/symlinked-config/_config.js

@@ -0,0 +1,5 @@
+module.exports = {
+	description: 'loads a symlinked config file',
+	command: 'rollup -c',
+	execute: true
+};

test/cli/samples/symlinked-config/main.js

@@ -0,0 +1 @@
+assert.equal(ANSWER, 42);

test/cli/samples/symlinked-config/rollup.config.js

@@ -0,0 +1 @@
+rollup.config.symlinked

test/cli/samples/symlinked-config/rollup.config.symlinked

@@ -0,0 +1,11 @@
+import replace from '@rollup/plugin-replace';
+
+export default {
+	input: 'main.js',
+	output: {
+		format: 'cjs'
+	},
+	plugins: [
+		replace({ 'ANSWER': 42 })
+	]
+};

test/cli/samples/symlinked-named-config/_config.js

@@ -0,0 +1,5 @@
+module.exports = {
+	description: 'loads a symlinked config file with the given name',
+	command: 'rollup --config my.rollup.config.js',
+	execute: true
+};

test/cli/samples/symlinked-named-config/main.js

@@ -0,0 +1 @@
+assert.equal(ANSWER, 42);

test/cli/samples/symlinked-named-config/my.rollup.config.js

@@ -0,0 +1 @@
+rollup.config.symlinked

test/cli/samples/symlinked-named-config/rollup.config.symlinked

@@ -0,0 +1,11 @@
+import replace from '@rollup/plugin-replace';
+
+export default {
+	input: 'main.js',
+	output: {
+		format: 'cjs'
+	},
+	plugins: [
+		replace({ 'ANSWER': 42 })
+	]
+};