Completely omit files that do not have any included statements

rollup · Jun 14, 2019 · 9f3e5a3 · 9f3e5a3
1 parent 74a3be1
commit 9f3e5a3
Show file tree

Hide file tree

Showing 13 changed files with 49 additions and 67 deletions.
diff --git a/src/Chunk.ts b/src/Chunk.ts
@@ -528,30 +528,36 @@ export default class Chunk {
 
 		for (let i = 0; i < this.orderedModules.length; i++) {
 			const module = this.orderedModules[i];
-			const source = module.render(renderOptions);
-			source.trim();
-			if (options.compact && source.lastLine().indexOf('//') !== -1) source.append('\n');
-			this.renderedModuleSources.push(source);
+			let renderedLength;
+			if (module.isIncluded()) {
+				const source = module.render(renderOptions);
+				source.trim();
+				if (options.compact && source.lastLine().indexOf('//') !== -1) source.append('\n');
+				this.renderedModuleSources.push(source);
+
+				const namespace = module.getOrCreateNamespace();
+				if (namespace.included) {
+					magicString.addSource(source);
+					this.usedModules.push(module);
+
+					if (namespace.included && !this.graph.preserveModules) {
+						const rendered = namespace.renderBlock(renderOptions);
+						if (namespace.renderFirst()) hoistedSource += n + rendered;
+						else magicString.addSource(new MagicString(rendered));
+					}
+				}
+				renderedLength = source.length();
+			} else {
+				renderedLength = 0;
+			}
 
 			const { renderedExports, removedExports } = module.getRenderedExports();
 			renderedModules[module.id] = {
 				originalLength: module.originalCode.length,
 				removedExports,
 				renderedExports,
-				renderedLength: source.length()
+				renderedLength
 			};
-
-			const namespace = module.getOrCreateNamespace();
-			if (namespace.included || !source.isEmpty()) {
-				magicString.addSource(source);
-				this.usedModules.push(module);
-
-				if (namespace.included && !this.graph.preserveModules) {
-					const rendered = namespace.renderBlock(renderOptions);
-					if (namespace.renderFirst()) hoistedSource += n + rendered;
-					else magicString.addSource(new MagicString(rendered));
-				}
-			}
 		}
 
 		if (hoistedSource) magicString.prepend(hoistedSource + n + n);

diff --git a/test/form/samples/remove-treeshaken-banners/_config.js b/test/form/samples/remove-treeshaken-banners/_config.js
@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'Also remove banner comments when completely tree-shaking files'
+};
diff --git a/test/form/samples/remove-treeshaken-banners/_expected.js b/test/form/samples/remove-treeshaken-banners/_expected.js
@@ -0,0 +1,4 @@
+// dep included banner: included
+console.log('dep included');
+
+// dep included footer: included
diff --git a/test/form/samples/remove-treeshaken-banners/dep-included.js b/test/form/samples/remove-treeshaken-banners/dep-included.js
@@ -0,0 +1,6 @@
+// dep included banner: included
+
+const removed = 1;
+console.log('dep included');
+
+// dep included footer: included
diff --git a/test/form/samples/remove-treeshaken-banners/dep-removed.js b/test/form/samples/remove-treeshaken-banners/dep-removed.js
@@ -0,0 +1,5 @@
+// dep removed banner: removed
+
+const removed = 1;
+
+// dep removed footer: removed
diff --git a/test/form/samples/remove-treeshaken-banners/main.js b/test/form/samples/remove-treeshaken-banners/main.js
@@ -0,0 +1,6 @@
+// main banner: removed
+
+import './dep-removed';
+import './dep-included';
+
+// main footer: removed
diff --git a/test/form/samples/tree-shake-default-exports/_expected/amd.js b/test/form/samples/tree-shake-default-exports/_expected/amd.js
@@ -1,13 +1,5 @@
 define(function () { 'use strict';
 
-	/* header 1 */
-
-	/* footer 1 */
-
-	/* header 2 */
-
-	/* footer 2 */
-
 	/* header 3 */
 
 	/* leading retained */

diff --git a/test/form/samples/tree-shake-default-exports/_expected/cjs.js b/test/form/samples/tree-shake-default-exports/_expected/cjs.js
@@ -1,13 +1,5 @@
 'use strict';
 
-/* header 1 */
-
-/* footer 1 */
-
-/* header 2 */
-
-/* footer 2 */
-
 /* header 3 */
 
 /* leading retained */

diff --git a/test/form/samples/tree-shake-default-exports/_expected/es.js b/test/form/samples/tree-shake-default-exports/_expected/es.js
@@ -1,11 +1,3 @@
-/* header 1 */
-
-/* footer 1 */
-
-/* header 2 */
-
-/* footer 2 */
-
 /* header 3 */
 
 /* leading retained */

diff --git a/test/form/samples/tree-shake-default-exports/_expected/iife.js b/test/form/samples/tree-shake-default-exports/_expected/iife.js
@@ -1,14 +1,6 @@
 (function () {
 	'use strict';
 
-	/* header 1 */
-
-	/* footer 1 */
-
-	/* header 2 */
-
-	/* footer 2 */
-
 	/* header 3 */
 
 	/* leading retained */

diff --git a/test/form/samples/tree-shake-default-exports/_expected/system.js b/test/form/samples/tree-shake-default-exports/_expected/system.js
@@ -3,14 +3,6 @@ System.register([], function () {
 	return {
 		execute: function () {
 
-			/* header 1 */
-
-			/* footer 1 */
-
-			/* header 2 */
-
-			/* footer 2 */
-
 			/* header 3 */
 
 			/* leading retained */

diff --git a/test/form/samples/tree-shake-default-exports/_expected/umd.js b/test/form/samples/tree-shake-default-exports/_expected/umd.js
@@ -3,14 +3,6 @@
 	factory();
 }(function () { 'use strict';
 
-	/* header 1 */
-
-	/* footer 1 */
-
-	/* header 2 */
-
-	/* footer 2 */
-
 	/* header 3 */
 
 	/* leading retained */

diff --git a/test/misc/bundle-information.js b/test/misc/bundle-information.js
@@ -423,7 +423,7 @@ console.log(other);Promise.all([import('./dynamic1'), import('./dynamic2')]).the
 				input: ['input'],
 				plugins: [
 					loader({
-						input: 'export { renderedFn, renderedClass, renderedConst } from "code"',
+						input: '/* removed header */ export { renderedFn, renderedClass, renderedConst } from "code"',
 						code:
 							'export function renderedFn() {}\nexport function removedFn() {}\n' +
 							'export class renderedClass {}\nexport class removedClass {}\n' +
@@ -457,7 +457,7 @@ console.log(other);Promise.all([import('./dynamic1'), import('./dynamic2')]).the
 							renderedLength: 72
 						},
 						input: {
-							originalLength: 63,
+							originalLength: 84,
 							removedExports: [],
 							renderedExports: [],
 							renderedLength: 0