Include all relevant modules to generate reexports for implicit depen…

…dencies (#3688)

package.json

@@ -83,7 +83,7 @@
     "acorn-walk": "^7.2.0",
     "buble": "^0.20.0",
     "chokidar": "^3.4.1",
-    "codecov": "^3.7.1",
+    "codecov": "^3.7.2",
     "colorette": "^1.2.1",
     "core-js": "^3.6.5",
     "cross-os": "^1.3.0",

src/Module.ts

@@ -292,7 +292,12 @@ export default class Module {
 		const additionalSideEffectModules = new Set<Module>();
 		const possibleDependencies = new Set(this.dependencies);
 		let dependencyVariables = this.imports;
-		if (this.isEntryPoint || this.includedDynamicImporters.length > 0 || this.namespace.included) {
+		if (
+			this.isEntryPoint ||
+			this.includedDynamicImporters.length > 0 ||
+			this.namespace.included ||
+			this.implicitlyLoadedAfter.size > 0
+		) {
 			dependencyVariables = new Set(dependencyVariables);
 			for (const exportName of [...this.getReexports(), ...this.getExports()]) {
 				dependencyVariables.add(this.getVariableForExportName(exportName));

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_config.js

@@ -0,0 +1,20 @@
+module.exports = {
+	description: 'handles shared dependencies between implicit chunks without side-effects',
+	options: {
+		plugins: {
+			name: 'test-plugin',
+			buildStart() {
+				this.emitFile({
+					type: 'chunk',
+					id: 'core.js',
+					implicitlyLoadedAfterOneOf: ['main']
+				});
+				this.emitFile({
+					type: 'chunk',
+					id: 'button.js',
+					implicitlyLoadedAfterOneOf: ['main']
+				});
+			}
+		}
+	}
+};

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/amd/generated-button.js

@@ -0,0 +1,7 @@
+define(['exports', './main'], function (exports, main) { 'use strict';
+
+	const bar = main.foo + 'bar';
+
+	exports.bar = bar;
+
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/amd/generated-core.js

@@ -0,0 +1,7 @@
+define(['exports', './main'], function (exports, main) { 'use strict';
+
+
+
+	exports.foo = main.foo;
+
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/amd/main.js

@@ -0,0 +1,9 @@
+define(['exports'], function (exports) { 'use strict';
+
+	const foo = 'foo';
+
+	exports.foo = foo;
+
+	Object.defineProperty(exports, '__esModule', { value: true });
+
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/cjs/generated-button.js

@@ -0,0 +1,7 @@
+'use strict';
+
+var main = require('./main.js');
+
+const bar = main.foo + 'bar';
+
+exports.bar = bar;

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/cjs/generated-core.js

@@ -0,0 +1,7 @@
+'use strict';
+
+var main = require('./main.js');
+
+
+
+exports.foo = main.foo;

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/cjs/main.js

@@ -0,0 +1,7 @@
+'use strict';
+
+Object.defineProperty(exports, '__esModule', { value: true });
+
+const foo = 'foo';
+
+exports.foo = foo;

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/es/generated-button.js

@@ -0,0 +1,5 @@
+import { foo } from './main.js';
+
+const bar = foo + 'bar';
+
+export { bar };

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/es/generated-core.js

@@ -0,0 +1 @@
+export { foo } from './main.js';

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/es/main.js

@@ -0,0 +1,3 @@
+const foo = 'foo';
+
+export { foo };

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/system/generated-button.js

@@ -0,0 +1,14 @@
+System.register(['./main.js'], function (exports) {
+	'use strict';
+	var foo;
+	return {
+		setters: [function (module) {
+			foo = module.foo;
+		}],
+		execute: function () {
+
+			const bar = exports('bar', foo + 'bar');
+
+		}
+	};
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/system/generated-core.js

@@ -0,0 +1,13 @@
+System.register(['./main.js'], function (exports) {
+	'use strict';
+	return {
+		setters: [function (module) {
+			exports('foo', module.foo);
+		}],
+		execute: function () {
+
+
+
+		}
+	};
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/_expected/system/main.js

@@ -0,0 +1,10 @@
+System.register([], function (exports) {
+	'use strict';
+	return {
+		execute: function () {
+
+			const foo = exports('foo', 'foo');
+
+		}
+	};
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/button.js

@@ -0,0 +1 @@
+export { bar } from './shared/button';

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/core.js

@@ -0,0 +1 @@
+export { foo } from './shared/core.js';

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/main.js

@@ -0,0 +1 @@
+export { foo } from './shared/core.js';

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/shared/button.js

@@ -0,0 +1,2 @@
+import { foo } from './core.js';
+export const bar = foo + 'bar';

test/chunking-form/samples/implicit-dependencies/shared-dependency-no-side-effect/shared/core.js

@@ -0,0 +1 @@
+export const foo = 'foo';

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_config.js

@@ -0,0 +1,15 @@
+module.exports = {
+	description: 'handles shared dependencies when there are only reexports',
+	options: {
+		plugins: {
+			name: 'test-plugin',
+			buildStart() {
+				this.emitFile({
+					type: 'chunk',
+					id: 'implicit.js',
+					implicitlyLoadedAfterOneOf: ['main']
+				});
+			}
+		}
+	}
+};

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/amd/generated-implicit.js

@@ -0,0 +1,7 @@
+define(['exports', './main'], function (exports, main) { 'use strict';
+
+
+
+	exports.foo = main.foo;
+
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/amd/main.js

@@ -0,0 +1,9 @@
+define(['exports'], function (exports) { 'use strict';
+
+	const foo = 'shared';
+
+	exports.foo = foo;
+
+	Object.defineProperty(exports, '__esModule', { value: true });
+
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/cjs/generated-implicit.js

@@ -0,0 +1,7 @@
+'use strict';
+
+var main = require('./main.js');
+
+
+
+exports.foo = main.foo;

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/cjs/main.js

@@ -0,0 +1,7 @@
+'use strict';
+
+Object.defineProperty(exports, '__esModule', { value: true });
+
+const foo = 'shared';
+
+exports.foo = foo;

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/es/generated-implicit.js

@@ -0,0 +1 @@
+export { foo } from './main.js';

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/es/main.js

@@ -0,0 +1,3 @@
+const foo = 'shared';
+
+export { foo };

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/system/generated-implicit.js

@@ -0,0 +1,13 @@
+System.register(['./main.js'], function (exports) {
+	'use strict';
+	return {
+		setters: [function (module) {
+			exports('foo', module.foo);
+		}],
+		execute: function () {
+
+
+
+		}
+	};
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/_expected/system/main.js

@@ -0,0 +1,10 @@
+System.register([], function (exports) {
+	'use strict';
+	return {
+		execute: function () {
+
+			const foo = exports('foo', 'shared');
+
+		}
+	};
+});

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/implicit.js

@@ -0,0 +1 @@
+export * from './shared.js';

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/main.js

@@ -0,0 +1 @@
+export * from './shared.js';

test/chunking-form/samples/implicit-dependencies/shared-dependency-reexport/shared.js

@@ -0,0 +1 @@
+export const foo = 'shared';