You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm not sure why my previous comment isn't visible here. But I think this change is wrong and prevents 'others' (in my case cy-rollup) to error when they require('rollup/dist/loadConfigFile') ...
bbfdedd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm not sure why my previous comment isn't visible here. But I think this change is wrong and prevents 'others' (in my case cy-rollup) to error when they require('rollup/dist/loadConfigFile') ...
Check out the docs regarding subpath patterns:
https://nodejs.org/api/packages.html#packages_subpath_patterns
I think you need to do: "./dist/*": "./dist/*.js"
Changing this locally brings everything back to normal for me.
bbfdedd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for bothering you on multiple places, I just realized that my previous comment was on the pull request.