[v3.0] Change default for preserveEntrySignatures to exports-only (#4576

)
rollup · Jul 29, 2022 · d196046 · d196046
1 parent ab391de
commit d196046
Show file tree

Hide file tree

Showing 26 changed files with 7 additions and 162 deletions.
diff --git a/docs/999-big-list-of-options.md b/docs/999-big-list-of-options.md
@@ -1157,7 +1157,7 @@ If the code is invalid, a warning will be issued. Note that no error is thrown s
 
 #### preserveEntrySignatures
 
-Type: `"strict" | "allow-extension" | "exports-only" | false`<br> CLI: `--preserveEntrySignatures <strict|allow-extension>`/`--no-preserveEntrySignatures`<br> Default: `"strict"`
+Type: `"strict" | "allow-extension" | "exports-only" | false`<br> CLI: `--preserveEntrySignatures <strict|allow-extension>`/`--no-preserveEntrySignatures`<br> Default: `"exports-only"`
 
 Controls if Rollup tries to ensure that entry chunks have the same exports as the underlying entry module.
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rollup",
-  "version": "3.0.0-1",
+  "version": "3.0.0-2",
   "description": "Next-generation ES module bundler",
   "main": "dist/rollup.js",
   "module": "dist/es/rollup.js",

diff --git a/src/Chunk.ts b/src/Chunk.ts
@@ -52,7 +52,7 @@ import {
 	namespaceInteropHelpersByInteropType
 } from './utils/interopHelpers';
 import { basename, extname, isAbsolute } from './utils/path';
-import relativeId, { getAliasName, getImportPath } from './utils/relativeId';
+import { getAliasName, getImportPath } from './utils/relativeId';
 import type { RenderOptions } from './utils/renderHelpers';
 import { makeUnique, renderNamePattern } from './utils/renderNamePattern';
 import { MISSING_EXPORT_SHIM_VARIABLE } from './utils/variableNames';
@@ -297,21 +297,6 @@ export default class Chunk {
 		const moduleExportNamesByVariable = module.getExportNamesByVariable();
 		for (const exposedVariable of this.exports) {
 			if (!moduleExportNamesByVariable.has(exposedVariable)) {
-				if (
-					moduleExportNamesByVariable.size === 0 &&
-					module.isUserDefinedEntryPoint &&
-					module.preserveSignature === 'strict' &&
-					this.unsetOptions.has('preserveEntrySignatures')
-				) {
-					this.inputOptions.onwarn({
-						code: 'EMPTY_FACADE',
-						id: module.id,
-						message: `To preserve the export signature of the entry module "${relativeId(
-							module.id
-						)}", an empty facade chunk was created. This often happens when creating a bundle for a web app where chunks are placed in script tags and exports are ignored. In this case it is recommended to set "preserveEntrySignatures: false" to avoid this and reduce the number of chunks. Otherwise if this is intentional, set "preserveEntrySignatures: 'strict'" explicitly to silence this warning.`,
-						url: 'https://rollupjs.org/guide/en/#preserveentrysignatures'
-					});
-				}
 				return false;
 			}
 		}

diff --git a/src/utils/options/normalizeInputOptions.ts b/src/utils/options/normalizeInputOptions.ts
@@ -4,7 +4,6 @@ import type {
 	InputOptions,
 	ModuleSideEffectsOption,
 	NormalizedInputOptions,
-	PreserveEntrySignaturesOption,
 	RollupBuild,
 	WarningHandler
 } from '../../rollup/types';
@@ -55,7 +54,7 @@ export function normalizeInputOptions(config: InputOptions): {
 		onwarn,
 		perf: config.perf || false,
 		plugins: ensureArray(config.plugins),
-		preserveEntrySignatures: getPreserveEntrySignatures(config, unsetOptions),
+		preserveEntrySignatures: config.preserveEntrySignatures ?? 'exports-only',
 		preserveModules: getPreserveModules(config, onwarn, strictDeprecations),
 		preserveSymlinks: config.preserveSymlinks || false,
 		shimMissingExports: config.shimMissingExports || false,
@@ -219,19 +218,6 @@ const getModuleContext = (
 	return () => context;
 };
 
-const getPreserveEntrySignatures = (
-	config: InputOptions,
-	unsetOptions: Set<string>
-): NormalizedInputOptions['preserveEntrySignatures'] => {
-	const configPreserveEntrySignatures = config.preserveEntrySignatures as
-		| PreserveEntrySignaturesOption
-		| undefined;
-	if (configPreserveEntrySignatures == null) {
-		unsetOptions.add('preserveEntrySignatures');
-	}
-	return configPreserveEntrySignatures ?? 'strict';
-};
-
 const getPreserveModules = (
 	config: InputOptions,
 	warn: WarningHandler,

diff --git a/...ing-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/_config.js b/...ing-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/_config.js
diff --git a/...e-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/amd/generated-dynamic.js b/...e-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/amd/generated-dynamic.js
diff --git a/...rve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/amd/generated-entry.js b/...rve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/amd/generated-entry.js
diff --git a/...erve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/amd/generated-main.js b/...erve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/amd/generated-main.js
diff --git a/...e-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/cjs/generated-dynamic.js b/...e-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/cjs/generated-dynamic.js
diff --git a/...rve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/cjs/generated-entry.js b/...rve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/cjs/generated-entry.js
diff --git a/...erve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/cjs/generated-main.js b/...erve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/cjs/generated-main.js
diff --git a/...ve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/es/generated-dynamic.js b/...ve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/es/generated-dynamic.js
diff --git a/...erve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/es/generated-entry.js b/...erve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/es/generated-entry.js
diff --git a/...serve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/es/generated-main.js b/...serve-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/es/generated-main.js
diff --git a/...ntry-signatures/undefined-with-tainted-plugin-chunk/_expected/system/generated-dynamic.js b/...ntry-signatures/undefined-with-tainted-plugin-chunk/_expected/system/generated-dynamic.js
diff --git a/...-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/system/generated-entry.js b/...-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/system/generated-entry.js
diff --git a/...e-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/system/generated-main.js b/...e-entry-signatures/undefined-with-tainted-plugin-chunk/_expected/system/generated-main.js
diff --git a/...ing-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/dynamic.js b/...ing-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/dynamic.js
diff --git a/...hunking-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/lib.js b/...hunking-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/lib.js
diff --git a/...unking-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/main.js b/...unking-form/samples/preserve-entry-signatures/undefined-with-tainted-plugin-chunk/main.js
diff --git a/test/function/samples/options-hook/_config.js b/test/function/samples/options-hook/_config.js
@@ -28,7 +28,7 @@ module.exports = {
 							name: 'test-plugin'
 						}
 					],
-					preserveEntrySignatures: 'strict',
+					preserveEntrySignatures: 'exports-only',
 					preserveSymlinks: false,
 					shimMissingExports: false,
 					strictDeprecations: true,

diff --git a/test/function/samples/preserve-entry-signatures-empty-facade/_config.js b/test/function/samples/preserve-entry-signatures-empty-facade/_config.js
diff --git a/test/function/samples/preserve-entry-signatures-empty-facade/dynamic.js b/test/function/samples/preserve-entry-signatures-empty-facade/dynamic.js
diff --git a/test/function/samples/preserve-entry-signatures-empty-facade/lib.js b/test/function/samples/preserve-entry-signatures-empty-facade/lib.js
diff --git a/test/function/samples/preserve-entry-signatures-empty-facade/main.js b/test/function/samples/preserve-entry-signatures-empty-facade/main.js