Change writeBundle signature to match generateBundle

rollup · Jan 29, 2020 · f4bacc3 · f4bacc3
1 parent 771189e
commit f4bacc3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/src/rollup/rollup.ts b/src/rollup/rollup.ts
@@ -316,7 +316,7 @@ export async function rollupInternal(
 				await Promise.all(
 					Object.keys(bundle).map(chunkId => writeOutputFile(bundle[chunkId], outputOptions))
 				);
-				await outputPluginDriver.hookParallel('writeBundle', [bundle]);
+				await outputPluginDriver.hookParallel('writeBundle', [outputOptions, bundle]);
 				return createOutput(bundle);
 			});
 		}

diff --git a/src/rollup/types.d.ts b/src/rollup/types.d.ts
@@ -332,7 +332,11 @@ interface OutputPluginHooks {
 	resolveAssetUrl: ResolveAssetUrlHook;
 	resolveDynamicImport: ResolveDynamicImportHook;
 	resolveFileUrl: ResolveFileUrlHook;
-	writeBundle: (this: PluginContext, bundle: OutputBundle) => void | Promise<void>;
+	writeBundle: (
+		this: PluginContext,
+		options: OutputOptions,
+		bundle: OutputBundle
+	) => void | Promise<void>;
 }
 
 export interface PluginHooks extends OutputPluginHooks {

diff --git a/test/hooks/index.js b/test/hooks/index.js
@@ -620,7 +620,8 @@ describe('hooks', () => {
 						}
 					},
 					{
-						writeBundle(outputBundle) {
+						writeBundle(options, outputBundle) {
+							assert.deepStrictEqual(options.file, file);
 							assert.deepStrictEqual(outputBundle, bundle);
 							callCount++;
 						}