[v3.0] Show deprecation warning for maxParallelFileReads (#4575)

rollup · Jul 29, 2022 · ff65a10 · ff65a10
1 parent 2cc052b
commit ff65a10
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 6 deletions.
diff --git a/src/utils/options/normalizeInputOptions.ts b/src/utils/options/normalizeInputOptions.ts
@@ -185,7 +185,7 @@ const getmaxParallelFileOps = (
 	if (typeof maxParallelFileReads === 'number') {
 		warnDeprecationWithOptions(
 			'The "maxParallelFileReads" option is deprecated. Use the "maxParallelFileOps" option instead.',
-			false,
+			true,
 			warn,
 			strictDeprecations
 		);

diff --git a/test/function/samples/deprecated/max-parallel-file-reads/infinity/_config.js b/test/function/samples/deprecated/max-parallel-file-reads/infinity/_config.js
@@ -25,5 +25,12 @@ module.exports = {
 	after() {
 		fs.readFile = fsReadFile;
 		assert.strictEqual(maxReads, 5, 'Wrong number of parallel file reads: ' + maxReads);
-	}
+	},
+	warnings: [
+		{
+			code: 'DEPRECATED_FEATURE',
+			message:
+				'The "maxParallelFileReads" option is deprecated. Use the "maxParallelFileOps" option instead.'
+		}
+	]
 };
diff --git a/test/function/samples/deprecated/max-parallel-file-reads/set/_config.js b/test/function/samples/deprecated/max-parallel-file-reads/set/_config.js
@@ -25,5 +25,12 @@ module.exports = {
 	after() {
 		fs.readFile = fsReadFile;
 		assert.strictEqual(maxReads, 3, 'Wrong number of parallel file reads: ' + maxReads);
-	}
+	},
+	warnings: [
+		{
+			code: 'DEPRECATED_FEATURE',
+			message:
+				'The "maxParallelFileReads" option is deprecated. Use the "maxParallelFileOps" option instead.'
+		}
+	]
 };
diff --git a/test/function/samples/deprecated/max-parallel-file-reads/with-plugin/_config.js b/test/function/samples/deprecated/max-parallel-file-reads/with-plugin/_config.js
@@ -32,5 +32,12 @@ module.exports = {
 	after() {
 		fs.readFile = fsReadFile;
 		assert.strictEqual(maxReads, 3, 'Wrong number of parallel file reads: ' + maxReads);
-	}
+	},
+	warnings: [
+		{
+			code: 'DEPRECATED_FEATURE',
+			message:
+				'The "maxParallelFileReads" option is deprecated. Use the "maxParallelFileOps" option instead.'
+		}
+	]
 };
diff --git a/test/misc/sanity-checks.js b/test/misc/sanity-checks.js
@@ -197,10 +197,13 @@ describe('sanity checks', () => {
 	it('does not throw when using dynamic imports with the "file" option and "inlineDynamicImports"', async () => {
 		const bundle = await rollup.rollup({
 			input: 'x',
-			inlineDynamicImports: true,
 			plugins: [loader({ x: 'console.log( "x" );import("y");', y: 'console.log( "y" );' })]
 		});
-		await bundle.generate({ file: 'x', format: 'es' });
+		await bundle.generate({
+			file: 'x',
+			format: 'es',
+			inlineDynamicImports: true
+		});
 	});
 
 	it('throws when using the object form of "input" together with the "file" option', async () => {