New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemJS renderer setter uses shadowed variable name `module` #3613

Closed

joeljeske opened this issue Jun 3, 2020 · 2 comments · Fixed by #3614

Labels

Contributor

joeljeske commented Jun 3, 2020

Rollup Version: 2.12.1
Operating System (or Browser):
Node Version (if applicable):
Link to reproduction (IMPORTANT, read below):

https://rollupjs.org/repl/?version=2.12.1&shareable=JTdCJTIybW9kdWxlcyUyMiUzQSU1QiU3QiUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QiUyMG1vZHVsZSUyQyUyMG90aGVyJTIwJTdEJTIwZnJvbSUyMCd0ZXN0JyUzQiU1Q24lNUNuY29uc29sZS5sb2cobW9kdWxlJTJDJTIwb3RoZXIpJTNCJTVDbiUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMnN5c3RlbSUyMiUyQyUyMm5hbWUlMjIlM0ElMjJteUJ1bmRsZSUyMiUyQyUyMmFtZCUyMiUzQSU3QiUyMmlkJTIyJTNBJTIyJTIyJTdEJTJDJTIyZ2xvYmFscyUyMiUzQSU3QiU3RCU3RCUyQyUyMmV4YW1wbGUlMjIlM0FudWxsJTdE

Expected Behavior

The name "module" can be used as a named export/import without collision

Actual Behavior

The name "module" collides with the SystemJS setters block causing type errors.

lukastaegert added the t¹ 🐞 bug label

guybedford mentioned this issue

Ensure system-reserved identifiers are deduped #3614

Merged

9 tasks

Contributor

guybedford commented Jun 3, 2020

Thanks so much for catching this @joeljeske, I've created a PR to fix this at #3614.

lukastaegert closed this as completed in #3614

Contributor Author

joeljeske commented Jun 4, 2020

Of course. Thanks for the quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment