Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure system-reserved identifiers are deduped #3614

Merged
merged 2 commits into from Jun 4, 2020
Merged

Conversation

guybedford
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Fixes #3613

@rollup-bot
Copy link
Collaborator

rollup-bot commented Jun 3, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#system-reserved

or load it into the REPL:
https://rollupjs.org/repl/?circleci=11635

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #3614 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         182      182           
  Lines        6210     6212    +2     
  Branches     1820     1819    -1     
=======================================
+ Hits         5986     5988    +2     
  Misses        111      111           
  Partials      113      113           
Impacted Files Coverage Δ
src/Chunk.ts 99.79% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c075e...ae4a3bc. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response 👍

@lukastaegert lukastaegert merged commit 22e372b into master Jun 4, 2020
@lukastaegert lukastaegert deleted the system-reserved branch June 4, 2020 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SystemJS renderer setter uses shadowed variable name module
3 participants