Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: this.emitFile support prebuilt-chunk type #4990

Merged
merged 10 commits into from May 22, 2023

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #4210

Description

This PR implements a basic feature about emitting prebuilt chunks, outlined in #4210 (comment)

@vercel
Copy link

vercel bot commented May 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 4:52am

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #4990 (abaafeb) into master (0ee31f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head abaafeb differs from pull request most recent head 28be756. Consider uploading reports for the commit 28be756 to get more accurate results

@@           Coverage Diff           @@
##           master    #4990   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         222      222           
  Lines        8157     8175   +18     
  Branches     2243     2250    +7     
=======================================
+ Hits         8073     8091   +18     
  Misses         30       30           
  Partials       54       54           
Impacted Files Coverage Δ
src/utils/FileEmitter.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However, we need some more tests, and then we need to update the documentation.

src/utils/FileEmitter.ts Outdated Show resolved Hide resolved
src/utils/FileEmitter.ts Show resolved Hide resolved
src/utils/FileEmitter.ts Show resolved Hide resolved
src/utils/FileEmitter.ts Outdated Show resolved Hide resolved
src/utils/FileEmitter.ts Show resolved Hide resolved
src/utils/FileEmitter.ts Show resolved Hide resolved
@TrickyPi
Copy link
Member Author

Thanks for your review! I'll update the documentation tomorrow.

@TrickyPi
Copy link
Member Author

docs has been updated.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I slightly changed the wording of the docs, but overall I will release this now.

@lukastaegert lukastaegert merged commit 06e9045 into rollup:master May 22, 2023
10 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.23.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an way to modify Emited chunk in generateBundle | writeBundle hooks
3 participants