New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: this.emitFile support prebuilt-chunk type #4990
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #4990 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 222 222
Lines 8157 8175 +18
Branches 2243 2250 +7
=======================================
+ Hits 8073 8091 +18
Misses 30 30
Partials 54 54
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! However, we need some more tests, and then we need to update the documentation.
1c8bb9f
to
d2d53c1
Compare
Thanks for your review! I'll update the documentation tomorrow. |
8d361d8
to
683803c
Compare
3c1265d
to
e1803cf
Compare
docs has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I slightly changed the wording of the docs, but overall I will release this now.
This PR has been released as part of rollup@3.23.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #4210
Description
This PR implements a basic feature about emitting prebuilt chunks, outlined in #4210 (comment)