[commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker #5258

GuichiZhao · 2023-11-20T07:06:50Z

Rollup Version

4.5.0

Operating System (or Browser)

Ubuntu 22.04.3 LTS

Node Version (if applicable)

v20.6.1

Link To Reproduction

https://vitejs.dev/

Expected Behaviour

Report
RollupError: Expected '(', got 'string literal (object, 'object')' after upgrade vite 5, the error disappears after bringing back to vite 4, obviously there is something wrong with the rollup parser, it can not parse a legal syntax somehow

else if (typeof module !== "undefined" && module.exports) should be a valid javascript syntax

Actual Behaviour

Report error

The text was updated successfully, but these errors were encountered:

lukastaegert · 2023-11-20T07:55:08Z

Do you have an actual reproduction we can have a look at? E.g. something in the Rollup REPL?

GuichiZhao · 2023-11-20T09:28:55Z

@lukastaegert It is a super complicate project, I am trying to strip it down

GuichiZhao · 2023-11-20T10:49:01Z

Sorry, I can not reproduce the bug, just some more hint hopefully it will be helpful

The [commonjs-resolve] can not parse the umd file which come from

    "node_modules/lerc": {
      "version": "3.0.0",
      "resolved": "https://registry.npmjs.org/lerc/-/lerc-3.0.0.tgz",
      "integrity": "sha512-Rm4J/WaHhRa93nCN2mwWDZFoRVF18G1f47C+kvQWyHGEZxFpTUi73p7lMVSAndyxGt6lJ2/CFbOcf9ra5p8aww=="
    },

which in turn required by

    "node_modules/geotiff": {
      "version": "2.1.0",
      "resolved": "https://registry.npmjs.org/geotiff/-/geotiff-2.1.0.tgz",
      "integrity": "sha512-B/iFJuFfRpmPHXf8aIRPRgUWwfaNb6dlsynkM8SWeHAPu7CpyvfqEa43KlBt7xxq5OTVysQacFHxhCn3SZhRKQ==",
      "dependencies": {
        "@petamoriken/float16": "^3.4.7",
        "lerc": "^3.0.0",
        "pako": "^2.0.4",
        "parse-headers": "^2.0.2",
        "quick-lru": "^6.1.1",
        "web-worker": "^1.2.0",
        "xml-utils": "^1.0.2",
        "zstddec": "^0.1.0"
      },
      "engines": {
        "node": ">=10.19"
      }
    },

and finally required by

    "node_modules/geotiff": {
      "version": "2.1.0",
      "resolved": "https://registry.npmjs.org/geotiff/-/geotiff-2.1.0.tgz",
      "integrity": "sha512-B/iFJuFfRpmPHXf8aIRPRgUWwfaNb6dlsynkM8SWeHAPu7CpyvfqEa43KlBt7xxq5OTVysQacFHxhCn3SZhRKQ==",
      "dependencies": {
        "@petamoriken/float16": "^3.4.7",
        "lerc": "^3.0.0",
        "pako": "^2.0.4",
        "parse-headers": "^2.0.2",
        "quick-lru": "^6.1.1",
        "web-worker": "^1.2.0",
        "xml-utils": "^1.0.2",
        "zstddec": "^0.1.0"
      },
      "engines": {
        "node": ">=10.19"
      }
    },

All I can observe is that the dependency path is quite deep, will it trick the [commonjs-resolve] somehow?
Another observation I can make is that when I comment out some real code not import statement, the build can pass but it is not reliable , I guess there is some kind of cache I do not know

For now, switching back to the old version solve my problem

sapphi-red · 2023-11-20T10:59:55Z

Rollup doesn't throw an error if I pass in the content of lerc@3.0.0/LercDecode.js.
I guess one of the plugin is generating invalid code.

ThenTech · 2023-11-20T11:06:50Z

I just encountered the exact same issue, also in the lerc package (imported by geotiff which is used by OpenLayers).

On Windows, with:

"rollup": "4.5.0",
"vite": "5.0.0",

Original error:

[vite-plugin-pwa:build] Expected '(', got 'string literal (object, 'object')'
file: /node_modules/.pnpm/lerc@3.0.0/node_modules/lerc/LercDecode.js:2314:10
2312:     define([], function() { return Lerc; });/* jshint ignore:line */
2313:   }
2314:   else if (typeof module !== "undefined" && module.exports) {/* jshint ignore:line */
                ^
2315:     //commonJS module 1.0/1.1/1.1.1 systems, such as nodeJS
2316:     //http://wiki.commonjs.org/wiki/Modules
error during build:
RollupError: Expected '(', got 'string literal (object, 'object')'
    at error (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30)
    at nodeConverters (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:2090:9)
    at convertNode (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:975:12)
    at convertProgram (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:966:48)
    at parseAstAsync (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:2156:20)
    at async Module.tryParseAsync (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/node-entry.js:13490:21)
    at async Module.setSource (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/node-entry.js:13071:35)
    at async ModuleLoader.addModuleSource (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/node-entry.js:17713:13)

Manually putting typeof module in that file:

[vite-plugin-pwa:build] Expected ',', got 'e'
file: /node_modules/.pnpm/lerc@3.0.0/node_modules/lerc/LercDecode.js:2310:39
2310:     console.log(">>><<< ", typeof module)
                                             ^
error during build:
RollupError: Expected ',', got 'e'
    at error (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:337:30)
    at nodeConverters (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:2090:9)
    at convertNode (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:975:12)
    at convertProgram (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:966:48)
    at parseAstAsync (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/parseAst.js:2156:20)
    at async Module.tryParseAsync (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/node-entry.js:13490:21)
    at async Module.setSource (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/node-entry.js:13071:35)
    at async ModuleLoader.addModuleSource (/node_modules/.pnpm/rollup@4.5.0/node_modules/rollup/dist/es/shared/node-entry.js:17713:13)

As @GuichiZhao says, it doesn't happen in Vite v4.5, only in v5

Edit: If I remove vite-plugin-pwa the same error shows with commonjs--resolver instead, just as @GuichiZhao also showed.

simon04 · 2023-11-21T08:25:44Z

Here's a minimal example to reproduce (involving only rollup 4.5.0, without vite): https://github.com/simon04/ol-rollup/tree/rollup-5258

sapphi-red · 2023-11-21T14:24:06Z

It didn't reproduce in stackblitz but reproduced on my local Windows machine. The code after transformed by commonjs plugin was

if (typeofundefinede === "function" &&undefinede.amd) {/* jshint ignore:line */
	    //amd loaders such as dojo and requireJS
	    //http://wiki.commonjs.org/wiki/Modules/AsynchronousDefinition
	   undefinede([], function() { return Lerc; });/* jshint ignore:line */
	  }
	  else if 'object'e !== "undefined" && module.exports) {/* jshint ignore:line */
	    //commonJS module 1.0/1.1/1.1.1 systems, such as nodeJS
	    //http://wiki.commonjs.org/wiki/Modules
	    module.exports = Lerc;/* jshint ignore:line */
	  }
	  else {
	    //assign to this, most likely window
	    this.Lerc = Lerc;
	  }

I found that node_modules/lerc/LercDecode.js has a BOM. If I saved it without BOM, the build was successful. I guess it's related to the BOM handling.

refs #5162, #5164

github-actions · 2023-11-24T06:30:19Z

This issue has been resolved via #5268 as part of rollup@4.5.2. You can test it via npm install rollup.

GuichiZhao added t¹ 🐞 bug t⁸ ⋅ triage labels Nov 20, 2023

This was referenced Nov 21, 2023

请升级一下lerc依赖 geotiffjs/geotiff.js#412

Open

chore(deps-dev): bump vite from 4.5.0 to 5.0.0 EOX-A/EOxElements#432

Closed

GuichiZhao changed the title ~~Can not parse umd file properly~~ [commonjs-resolver] can not parse und file properly (possibly)due to BOM marker Nov 22, 2023

GuichiZhao changed the title ~~[commonjs-resolver] can not parse und file properly (possibly)due to BOM marker~~ [commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker Nov 22, 2023

TrickyPi removed the t⁸ ⋅ triage label Nov 23, 2023

TrickyPi self-assigned this Nov 23, 2023

TrickyPi mentioned this issue Nov 23, 2023

fix: strip BOM before calling transform hook #5268

Merged

9 tasks

lukastaegert closed this as completed in #5268 Nov 24, 2023

sideral mentioned this issue Nov 30, 2023

ESM and ViteJS 5 : Building error with density-clustering Turfjs/turf#2541

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker #5258

[commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker #5258

GuichiZhao commented Nov 20, 2023 •

edited

lukastaegert commented Nov 20, 2023

GuichiZhao commented Nov 20, 2023 •

edited

GuichiZhao commented Nov 20, 2023

sapphi-red commented Nov 20, 2023 •

edited

ThenTech commented Nov 20, 2023 •

edited

simon04 commented Nov 21, 2023

sapphi-red commented Nov 21, 2023

github-actions bot commented Nov 24, 2023

[commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker #5258

[commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker #5258

Comments

GuichiZhao commented Nov 20, 2023 • edited

Rollup Version

Operating System (or Browser)

Node Version (if applicable)

Link To Reproduction

Expected Behaviour

Actual Behaviour

lukastaegert commented Nov 20, 2023

GuichiZhao commented Nov 20, 2023 • edited

GuichiZhao commented Nov 20, 2023

sapphi-red commented Nov 20, 2023 • edited

ThenTech commented Nov 20, 2023 • edited

simon04 commented Nov 21, 2023

sapphi-red commented Nov 21, 2023

github-actions bot commented Nov 24, 2023

GuichiZhao commented Nov 20, 2023 •

edited

GuichiZhao commented Nov 20, 2023 •

edited

sapphi-red commented Nov 20, 2023 •

edited

ThenTech commented Nov 20, 2023 •

edited