Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip BOM before calling transform hook #5268

Merged
merged 1 commit into from Nov 24, 2023
Merged

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5258

Description

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 0:07am

Copy link

github-actions bot commented Nov 23, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/xiaopi-bom

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-959tpz9t0-rollup-js.vercel.app/repl/?pr=5268

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a083019) 98.87% compared to head (e8dc65c) 98.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5268   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         232      232           
  Lines        8945     8946    +1     
  Branches     2334     2334           
=======================================
+ Hits         8844     8845    +1     
  Misses         42       42           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@lukastaegert lukastaegert added this pull request to the merge queue Nov 24, 2023
Merged via the queue into master with commit 08da9ee Nov 24, 2023
27 checks passed
@lukastaegert lukastaegert deleted the fix/xiaopi-bom branch November 24, 2023 05:54
Copy link

This PR has been released as part of rollup@4.5.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker
2 participants