Refactors config validation, deprecation and unification logic. #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes undefined prints in watch tests, also moves stderr to src.
ankeetmaini
force-pushed
the
onwarn-args
branch
from
0093463
to
afd30df
Compare
|
@lukastaegert I think I've solved it this time. Hahaha! |
|
This work looks great. We've been working on a TypeScript conversion in #1806, which has seen some inconsistencies in supporting the highly dynamic options interfaces. I wonder if this would simplify that or make it harder... |
|
@guybedford To solve the inconsistencies among the CLI and node I've created base input/output options in the file mergeOptions.js which is now the central place for all options related logic. All entry points now fallback to it. I hope this will make it simpler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally raised for #1762. This builds on top of #1769