-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Finished] TypeScript conversion #1806
Merged
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
665f98c
lay foundations for TypeScript conversion
Rich-Harris 0c0edee
initial naive typscript conversion
guybedford aa961e5
deep dive into ast folder!
guybedford b461965
ast folder types, complete estree definitions
guybedford f6cd52a
finish porting Rich Harris branch
guybedford fb3a34c
moar types
guybedford 63d38d4
Add editorconfig file
lukastaegert f4619a0
Add some types for Module.ts (WIP)
lukastaegert 4b448e5
ast type fixing
guybedford b561a63
More types for Module.ts (WIP)
lukastaegert 3e4519d
add bin, browser, utils, initial watch types
guybedford c5da226
attempt finalisers, scopes, variables
guybedford 9891e4a
Make JSDoc a little happier
lukastaegert b2210b9
finish up bin types, attempt further scopes and variables
guybedford 70e565b
More Module typing
lukastaegert f36de4c
Finish typing Module.js
lukastaegert 2a9db67
Mark private methods and variables
lukastaegert 2d1b871
Type ExternalModule
lukastaegert 58b92d9
Type Bundle (WIP)
lukastaegert 265d646
complete types on bin, finalisers
guybedford cf49dc9
further attempts on Bundle
guybedford e1615cf
type tweaks
guybedford e71c9ec
module, bundle, finalisers polishing
guybedford f10abfb
A little more work on Bundle
lukastaegert 26ba833
Type transformBundle
lukastaegert 8079970
options refactor, bin and watch types complete
guybedford 2d7f38e
more progress on variables and scopes
guybedford 2d61040
node, variable polishes
guybedford aa5a63e
mergeOptions rename
guybedford bea8b7e
options types
guybedford ba25afe
Unify forEach callback signatures + more types
lukastaegert e4d1e38
Use UNKNOWN_ASSIGNMENT instead of UNDEFINED_ASSIGNMENT as it is basic…
lukastaegert 39cce93
Finish typing!
lukastaegert 3a70b47
remove callable expression abstraction, was only necessary to make ty…
guybedford ad8484b
downlevel iteration not necessary
guybedford File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this case resolved now? If so the comment here can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this now.