Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass codeSplitting generated filenames to onwrite hooks #2115

Closed
wants to merge 1 commit into from

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Apr 8, 2018

In case of codeSplitting there is no way to know what file got generated when it gets called and it's useful for onwrite hook

@guybedford
Copy link
Contributor

Thanks - this is a great approach, I'm just considering the plugin hooks around code splitting at the moment, and would like to put a bit more thought to the state contract of plugins. I'm even wondering if an asset emission API may make more sense here since we might need that for WASM as well. Will aim to come up with some feedback soon in reference to this. Further discussion welcome too.

@guybedford
Copy link
Contributor

I've posted #2126 to provide this functionality, where chunk.name effectively provides the same information.

@lukastaegert
Copy link
Member

Hi @Andarist, as #2208 (which is basically the revised version of #2126) has now been merged and released, does this meet your requirements and can this one be closed?

@Andarist
Copy link
Member Author

Andarist commented Jul 3, 2018

I'm not entirely sure, this was just a minor issue that I've noticed once. If I come across this issue again then gonna report it, for now I would consider this to be solved.

@Andarist Andarist closed this Jul 3, 2018
@Andarist Andarist deleted the onwrite-pass-file branch July 3, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants