chore: allow building/testing on cmd #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added shx to run the unix-style commands in a cross-platform way. Poweshell has aliases for these commands, but cmd doesn't.
lukastaegert
approved these changes
May 31, 2018
There was a problem hiding this comment.
Seems to be working for me. I'll give it a try, doesn't hurt if more people try out #2208, it is a huge refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
shxto run the unix-style commands in a cross-platform way. Powershell has aliases for these commands, but cmd doesn't.This was first brought up (by me) way back in #1210 (comment) but since I'm trying to check out #2208 and I'm unable to build/test locally via
cmdI figure it's worth sending this quick PR.